Improved *NumberingScheme code for Forward detectors

[Dr15Jones]

PR description:

• Moved from class to namespace. The code had no internal state so all the functions work fine as standalone functions.
• Converted C array use to std::vector. This avoids a warning from gcc12 and does automatic memory management.

PR validation:

Code compiles.

[Dr15Jones]

This is an alternative to #41942. [Which @makortel pointed out to me after I had already done this work]

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41979/35945

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimG4CMS/Forward/interface/BHMNumberingScheme.h modified in PR(s): Fix Walloc-size-larger-than warnings in SimG4CMS/Forward/*NumberingScheme #41942
  • File SimG4CMS/Forward/interface/BscNumberingScheme.h modified in PR(s): Fix Walloc-size-larger-than warnings in SimG4CMS/Forward/*NumberingScheme #41942
  • File SimG4CMS/Forward/interface/ZdcNumberingScheme.h modified in PR(s): Fix Walloc-size-larger-than warnings in SimG4CMS/Forward/*NumberingScheme #41942
  • File SimG4CMS/Forward/src/BHMNumberingScheme.cc modified in PR(s): Fix Walloc-size-larger-than warnings in SimG4CMS/Forward/*NumberingScheme #41942
  • File SimG4CMS/Forward/src/BscNumberingScheme.cc modified in PR(s): Fix Walloc-size-larger-than warnings in SimG4CMS/Forward/*NumberingScheme #41942
  • File SimG4CMS/Forward/src/ZdcNumberingScheme.cc modified in PR(s): Fix Walloc-size-larger-than warnings in SimG4CMS/Forward/*NumberingScheme #41942

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• SimG4CMS/Forward (simulation)

@civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@bsunanda, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9be0bc/33187/summary.html
COMMIT: 3f953b8
CMSSW: CMSSW_13_2_X_2023-06-15-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41979/33187/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3196062
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3196040
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

+1

My impression that the solution in this PR a bit better than in #41942 , full regression confirms.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1