-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[llvm] Update to version 18.1.6 #9200
Conversation
test parameters:
|
A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_1_X/master. @aandvalenzuela, @cmsbuild, @smuzaffar, @iarspider can you please review it and eventually sign? Thanks. |
cms-bot internal usage |
please test for CMSSW_14_1_CLANG_X |
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b8de6/39451/summary.html External BuildI found compilation error when building: [3405/6680] /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/build/tools/llvm-profdata -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/tools/llvm-profdata -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/build/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17 -MD -MT tools/llvm-profdata/CMakeFiles/llvm-profdata.dir/llvm-profdata.cpp.o -MF tools/llvm-profdata/CMakeFiles/llvm-profdata.dir/llvm-profdata.cpp.o.d -o tools/llvm-profdata/CMakeFiles/llvm-profdata.dir/llvm-profdata.cpp.o -c /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/tools/llvm-profdata/llvm-profdata.cpp [3406/6680] /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/build/tools/dsymutil -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/tools/dsymutil -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/build/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17 -MD -MT tools/dsymutil/CMakeFiles/dsymutil.dir/MachOUtils.cpp.o -MF tools/dsymutil/CMakeFiles/dsymutil.dir/MachOUtils.cpp.o.d -o tools/dsymutil/CMakeFiles/dsymutil.dir/MachOUtils.cpp.o -c /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/tools/dsymutil/MachOUtils.cpp [3407/6680] /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/build/tools/dsymutil -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/tools/dsymutil -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/build/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17 -MD -MT tools/dsymutil/CMakeFiles/dsymutil.dir/dsymutil.cpp.o -MF tools/dsymutil/CMakeFiles/dsymutil.dir/dsymutil.cpp.o.d -o tools/dsymutil/CMakeFiles/dsymutil.dir/dsymutil.cpp.o -c /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/tools/dsymutil/dsymutil.cpp [3408/6680] /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/build/tools/dsymutil -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/tools/dsymutil -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/build/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17 -MD -MT tools/dsymutil/CMakeFiles/dsymutil.dir/DwarfLinkerForBinary.cpp.o -MF tools/dsymutil/CMakeFiles/dsymutil.dir/DwarfLinkerForBinary.cpp.o.d -o tools/dsymutil/CMakeFiles/dsymutil.dir/DwarfLinkerForBinary.cpp.o -c /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/tools/dsymutil/DwarfLinkerForBinary.cpp ninja: build stopped: subcommand failed. error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.Mq0uPy (%build) RPM build errors: line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+llvm+18.1.6-8bc7be74528ffeea7b2f711cb6c15f6b Macro expanded in comment on line 368: %{pkginstroot}/lib64 |
@gartung , I am testing llvm 18.1.6 and it failed due to cms checker.
Can you please look in to this and provide a fix for https://github.com/cms-externals/llvm-project/tree/cms/release/18.x/1118c2e |
please test with cms-externals/llvm-project#14 for CMSSW_14_1_CLANG_X |
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b8de6/39457/summary.html External BuildI found compilation error when building: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-84cebedcc15589e75ae9e728d5113e2f/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/clang/tools/include-what-you-use/iwyu_ast_util.h:339:5: note: in expansion of macro 'CHECK_UNREACHABLE_' 339 | CHECK_UNREACHABLE_("Unknown kind"); | ^~~~~~~~~~~~~~~~~~ [5646/6680] /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -DIWYU_GIT_REV=\"\" -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-84cebedcc15589e75ae9e728d5113e2f/build/tools/clang/tools/include-what-you-use -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-84cebedcc15589e75ae9e728d5113e2f/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/clang/tools/include-what-you-use -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-84cebedcc15589e75ae9e728d5113e2f/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/clang/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-84cebedcc15589e75ae9e728d5113e2f/build/tools/clang/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-84cebedcc15589e75ae9e728d5113e2f/build/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-84cebedcc15589e75ae9e728d5113e2f/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-84cebedcc15589e75ae9e728d5113e2f/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/llvm/../clang/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG -std=c++17 -MD -MT tools/clang/tools/include-what-you-use/CMakeFiles/include-what-you-use.dir/iwyu_ast_util.cc.o -MF tools/clang/tools/include-what-you-use/CMakeFiles/include-what-you-use.dir/iwyu_ast_util.cc.o.d -o tools/clang/tools/include-what-you-use/CMakeFiles/include-what-you-use.dir/iwyu_ast_util.cc.o -c /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/llvm/18.1.6-84cebedcc15589e75ae9e728d5113e2f/llvm-18.1.6-0a498c5f36995dfa2810d831f7e42804003a3672/clang/tools/include-what-you-use/iwyu_ast_util.cc ninja: build stopped: subcommand failed. error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.NuGawQ (%build) RPM build errors: line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+llvm+18.1.6-84cebedcc15589e75ae9e728d5113e2f Macro expanded in comment on line 368: %{pkginstroot}/lib64 |
Pull request #9200 was updated. |
please test for CMSSW_14_1_CLANG_X |
I'd say returning
We have (disallowing
Moving away from VLAs (which would have its benefits) would need to be a separate discussion. See cms-sw/cmssw#44937 for some recent discussion. Maybe in some places the cost of dynamic memory allocation is negligible, but there are places where it has (or had) noticeable performance impact. |
void setNegAttributes(const float dRZ2 = std::numeric_limits<float>::infinity(),
const float dPhi2 = std::numeric_limits<float>::infinity(),
const float dRZ1 = std::numeric_limits<float>::infinity(),
const float dPhi1 = std::numeric_limits<float>::infinity());
void setPosAttributes(const float dRZ2 = std::numeric_limits<float>::infinity(),
const float dPhi2 = std::numeric_limits<float>::infinity(),
const float dRZ1 = std::numeric_limits<float>::infinity(),
const float dPhi1 = std::numeric_limits<float>::infinity()); |
Ah, ok. Maybe we should replace such comparisons as well with |
Pull request #9200 was updated. |
please test for CMSSW_14_1_CLANG_X |
-1 Failed Tests: UnitTests AddOn Unit TestsI found 1 errors in the following unit tests: ---> test RecoPPSLocalNewT2 had ERRORS AddOn Tests
Expand to see more addon errors ...
Comparison SummarySummary:
|
please test for CMSSW_14_1_CLANG_X |
-1 Failed Tests: UnitTests RelVals AddOn Unit TestsI found 1 errors in the following unit tests: ---> test RecoPPSLocalNewT2 had ERRORS RelValsAddOn Tests
Expand to see more addon errors ...
|
please test for CMSSW_14_1_CLANG_X |
looks good, lets get this in next CLANG IB |
Updating LLVM version to 18.1.6