Run3-alca247B Add new options for getting correction factors - to be used to understand the impact on JetMET corrections

[bsunanda]

PR description:

Add new options for getting correction factors - to be used to understand the impact of variation in algorithms on JetMET corrections

PR validation:

Some of the options are tried on 2024C data

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45113/40442

• This PR adds an extra 92KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45113/40442/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45113/40442/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45113/40443

• This PR adds an extra 92KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

• Calibration/HcalCalibAlgos (alca)

@saumyaphor4252, @cmsbuild, @perrotta, @consuegs can you please review it and eventually sign? Thanks.
@mmusich, @yuanchao, @rsreds, @tocheng this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d35269/39640/summary.html
COMMIT: 03d86bd
CMSSW: CMSSW_14_1_X_2024-05-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45113/39640/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 7.37.3_CosmicsSPLoose2018/step1_CosmicsSPLoose2018.log
• 8.08.0_BeamHalo/step1_BeamHalo.log
• 4.534.53_RunPhoton2012B/step2_RunPhoton2012B.log

Expand to see more relval errors ...

• 9.0
• 25.0
• 136.731
• 136.793
• 139.001
• 136.874
• 140.023
• 4.22
• 140.063
• 140.043
• 136.7611
• 5.1
• 136.88811
• 135.4
• 136.8311
• 141.042
• 141.044
• 1306.0
• 141.046
• 1330.0
• 312.0
• 140.56
• 25202.0
• 101.0
• 10224.0
• 158.01
• 12434.0
• 11634.0
• 12834.0
• 13034.0
• 12834.7
• 12846.0
• 13234.0
• 14234.0
• 14034.0
• 23234.0
• 24834.0
• 1000.0
• 24834.911
• 24896.0
• 24900.0
• 25034.999
• 250202.181
• 1001.0
• 2500.4

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d35269/39640/summary.html
COMMIT: 03d86bd
CMSSW: CMSSW_14_1_X_2024-05-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45113/39640/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
1000.0 step 2
1001.0 step 2
101.0 step 1
10224.0 step 1
11634.0 step 1
12434.0 step 1
12834.0 step 1
12834.7 step 1
12846.0 step 1
13034.0 step 1
1306.0 step 1
13234.0 step 1
1330.0 step 1
135.4 step 1
136.731 step 2
136.7611 step 2
136.793 step 2
136.8311 step 2
136.874 step 2
136.88811 step 2
139.001 step 2
140.023 step 2
140.043 step 2
140.063 step 2
140.56 step 2
14034.0 step 1
141.042 step 2
141.044 step 2
141.046 step 2
14234.0 step 1
158.01 step 2
23234.0 step 1
24834.0 step 1
24834.911 step 1
24896.0 step 1
24900.0 step 1
25.0 step 1
2500.4 step 2
250202.181 step 1
25034.999 step 1
25202.0 step 1
312.0 step 1
4.22 step 2
4.53 step 2
5.1 step 1
7.3 step 1
8.0 step 1
9.0 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially added 19178 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 1
• DQMHistoTests: Total histograms compared: 0
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 0
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
• Checked 66 log files, 0 edm output root files, 1 DQM output files

[perrotta]

We must rerun the tests because of the issues in the baseline.
Before doing so, you could have a look at the following observations about your description fields

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45113/40464

• This PR adds an extra 92KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45113/40464/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45113/40464/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45113/40465

• This PR adds an extra 92KB to repository

[cmsbuild]

Pull request #45113 was updated. @consuegs, @saumyaphor4252, @perrotta can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d35269/39680/summary.html
COMMIT: 34bf1cb
CMSSW: CMSSW_14_1_X_2024-06-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45113/39680/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3338862
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3338842
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1