Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[G4] Update Geant4 to version 11.3.0 #9556

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

iarspider
Copy link
Contributor

@iarspider iarspider commented Dec 6, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2024

A new Pull Request was created by @iarspider for branch IB/CMSSW_15_0_X/g4.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2024

cms-bot internal usage

@iarspider
Copy link
Contributor Author

please test for CMSSW_15_0_GEANT4_X

@iarspider
Copy link
Contributor Author

please test for CMSSW_15_0_G4VECGEOM_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2024

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-93ab83/43298/summary.html
COMMIT: a92a9b7
CMSSW: CMSSW_15_0_GEANT4_X_2024-12-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9556/43298/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-93ab83/43298/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-93ab83/43298/git-merge-result

Unit Tests

I found 6 errors in the following unit tests:

---> test TestDQMOnlineClient-sistrip_approx_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-pixel_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-sistrip_dqm_sourceclient had ERRORS
and more ...

Comparison Summary

There are some workflows for which there are errors in the baseline:
2022.000001 step 1
2022.002001 step 1
2023.002001 step 1
2024.000001 step 1
2024.101001 step 1
2024.202001 step 1
2024.303001 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 186 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 63961 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2952625
  • DQMHistoTests: Total failures: 370262
  • DQMHistoTests: Total nulls: 656
  • DQMHistoTests: Total successes: 2581687
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 4029.2789999999995 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): 138.555 KiB Muons/RecoMuonV
  • DQMHistoSizes: changed ( 10224.0 ): -0.544 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11634.0,... ): 146.206 KiB Muons/RecoMuonV
  • DQMHistoSizes: changed ( 13034.0 ): 0.899 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13234.0,... ): 107.437 KiB Muons/RecoMuonV
  • DQMHistoSizes: changed ( 16834.0 ): 69.473 KiB HLT/Muon
  • DQMHistoSizes: changed ( 24834.911,... ): 136.929 KiB HLT/Muon
  • DQMHistoSizes: changed ( 24834.911,... ): 76.538 KiB Muons/RecoMuonV
  • DQMHistoSizes: changed ( 250202.181 ): 0.299 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.372 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): ...
  • Checked 174 log files, 144 edm output root files, 39 DQM output files
  • TriggerResults: found differences in 11 / 37 workflows

@iarspider
Copy link
Contributor Author

+externals

Unit test failures seem unrelated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2024

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_15_0_X/g4 IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2024

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-93ab83/43299/summary.html
COMMIT: a92a9b7
CMSSW: CMSSW_15_0_G4VECGEOM_X_2024-12-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9556/43299/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-93ab83/43299/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-93ab83/43299/git-merge-result

Unit Tests

I found 6 errors in the following unit tests:

---> test TestDQMOnlineClient-sistrip_approx_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-sistrip_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-pixel_dqm_sourceclient had ERRORS
and more ...

Comparison Summary

There are some workflows for which there are errors in the baseline:
2022.000001 step 1
2022.002001 step 1
2023.002001 step 1
2024.000001 step 1
2024.101001 step 1
2024.202001 step 1
2024.303001 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 154 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 63743 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2952625
  • DQMHistoTests: Total failures: 369020
  • DQMHistoTests: Total nulls: 656
  • DQMHistoTests: Total successes: 2582929
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 4027.5260000000003 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): 138.555 KiB Muons/RecoMuonV
  • DQMHistoSizes: changed ( 10224.0 ): -0.661 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11634.0,... ): 146.206 KiB Muons/RecoMuonV
  • DQMHistoSizes: changed ( 13034.0 ): 1.706 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13234.0,... ): 107.437 KiB Muons/RecoMuonV
  • DQMHistoSizes: changed ( 16834.0 ): 69.473 KiB HLT/Muon
  • DQMHistoSizes: changed ( 24834.911,... ): 136.929 KiB HLT/Muon
  • DQMHistoSizes: changed ( 24834.911,... ): 76.538 KiB Muons/RecoMuonV
  • DQMHistoSizes: changed ( 250202.181 ): 0.245 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.660 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): ...
  • Checked 174 log files, 144 edm output root files, 39 DQM output files
  • TriggerResults: found differences in 14 / 37 workflows

@iarspider
Copy link
Contributor Author

iarspider commented Dec 7, 2024

please test with cms-sw/cmssw#46892 for CMSSW_15_0_GEANT4_X
just to be sure

@iarspider
Copy link
Contributor Author

please test with cms-sw/cmssw#46892 for CMSSW_15_0_G4VECGEOM_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-93ab83/43311/summary.html
COMMIT: a92a9b7
CMSSW: CMSSW_15_0_GEANT4_X_2024-12-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9556/43311/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-93ab83/43311/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-93ab83/43311/git-merge-result

Comparison Summary

There are some workflows for which there are errors in the baseline:
2022.000001 step 1
2022.002001 step 1
2023.002001 step 1
2024.000001 step 1
2024.101001 step 1
2024.202001 step 1
2024.303001 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 185 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 63961 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2952625
  • DQMHistoTests: Total failures: 373622
  • DQMHistoTests: Total nulls: 656
  • DQMHistoTests: Total successes: 2578327
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 4029.2789999999995 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): 138.555 KiB Muons/RecoMuonV
  • DQMHistoSizes: changed ( 10224.0 ): -0.544 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11634.0,... ): 146.206 KiB Muons/RecoMuonV
  • DQMHistoSizes: changed ( 13034.0 ): 0.899 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13234.0,... ): 107.437 KiB Muons/RecoMuonV
  • DQMHistoSizes: changed ( 16834.0 ): 69.473 KiB HLT/Muon
  • DQMHistoSizes: changed ( 24834.911,... ): 136.929 KiB HLT/Muon
  • DQMHistoSizes: changed ( 24834.911,... ): 76.538 KiB Muons/RecoMuonV
  • DQMHistoSizes: changed ( 250202.181 ): 0.299 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.372 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): ...
  • Checked 174 log files, 144 edm output root files, 39 DQM output files
  • TriggerResults: found differences in 11 / 37 workflows

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-93ab83/43312/summary.html
COMMIT: a92a9b7
CMSSW: CMSSW_15_0_G4VECGEOM_X_2024-12-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9556/43312/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-93ab83/43312/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-93ab83/43312/git-merge-result

Comparison Summary

There are some workflows for which there are errors in the baseline:
2022.000001 step 1
2022.002001 step 1
2023.002001 step 1
2024.000001 step 1
2024.101001 step 1
2024.202001 step 1
2024.303001 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 154 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 63739 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2952625
  • DQMHistoTests: Total failures: 372372
  • DQMHistoTests: Total nulls: 656
  • DQMHistoTests: Total successes: 2579577
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 4027.5260000000003 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): 138.555 KiB Muons/RecoMuonV
  • DQMHistoSizes: changed ( 10224.0 ): -0.661 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11634.0,... ): 146.206 KiB Muons/RecoMuonV
  • DQMHistoSizes: changed ( 13034.0 ): 1.706 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13234.0,... ): 107.437 KiB Muons/RecoMuonV
  • DQMHistoSizes: changed ( 16834.0 ): 69.473 KiB HLT/Muon
  • DQMHistoSizes: changed ( 24834.911,... ): 136.929 KiB HLT/Muon
  • DQMHistoSizes: changed ( 24834.911,... ): 76.538 KiB Muons/RecoMuonV
  • DQMHistoSizes: changed ( 250202.181 ): 0.245 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.660 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): ...
  • Checked 174 log files, 144 edm output root files, 39 DQM output files
  • TriggerResults: found differences in 14 / 37 workflows

@civanch
Copy link
Contributor

civanch commented Dec 9, 2024

It seems that it is possible to merge to GEANT4 and G4VECGEOM branches.

@smuzaffar smuzaffar merged commit e4184d2 into IB/CMSSW_15_0_X/g4 Dec 9, 2024
15 checks passed
@smuzaffar smuzaffar deleted the update-g4-11.3.rel branch December 18, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants