-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 141X data GTs in autoCond #46824
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46824/42829 |
A new Pull Request was created by @perrotta for master. It involves the following packages:
@atpathak, @cmsbuild, @consuegs, @perrotta can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Failed Tests: UnitTests Unit TestsI found 1 errors in the following unit tests: ---> test TestDQMOnlineClient-scal_dqm_sourceclient had ERRORS Comparison SummarySummary:
|
please test with #46742 |
abort |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46824/42833
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46824/42849 |
please test |
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
+alca
|
@cms-sw/dqm-l2 could you please either sign, or post here a comment about what you'd like to further investigate before doing it? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
just to notify that we will not be able to carry out the usual P5 tests for this PR since the playback system on which we run our tests (managed by Point 5 sysadmins) are offline for the YETS. |
+1 |
Thank you @antoniovagnerini |
Update online GTs in autoCond after the end of the 2024 data taking (to be used for tests and development):
run3_hlt
: 141X_dataRun3_HLT_frozen_v2run3_data_express
: 141X_dataRun3_Express_frozen_v4run3_data_prompt
: 141X_dataRun3_Prompt_frozen_v4Also the offline data GT needed to be fixed:
run3_data
: 141X_dataRun3_v5Moreover, to avoid crashes in the unit tests because of the removed (now unused) records in the HLT GT, the commit 6198154 comments out the
scal_dqm_sourceclient-live_cfg.py
test from the ones run in the unit tests of DQM/Integration: as correctly reported in a comment here below, the SCAL FED has been removed from DAQ since the end of Run 2.PR validation:
The removal of the not-needed records from the HLT GT was verified online as documented in CMSALCAFAST-94
Rely on these PR tests for a wider coverage