archaelogy: tracking code damage from automatic (or centralized manual) forward ports in 71X

[slava77]

we were trying to track down a part of the history of changes in RecoTracker/CkfPattern/python/CkfTrackCandidates_cfi.py

specifically, a change in #2291 was merged on Fri Feb 21, 2014 and entered https://github.com/cms-sw/cmssw/releases/tag/CMSSW_7_1_0_pre3
This entered the history as commit ab1d806

After that, based on git log, there is another commit that merges a 70X PR #2410 in commit b0669c7 from Mon Mar 24, 2014. This happened shortly after CMSSW_7_1_0_pre5 was made and does not show up in the following pre-release https://github.com/cms-sw/cmssw/releases/tag/CMSSW_7_1_0_pre6

If I'm not mistaken, the full range of differences is in 17b09fe...da8c157

[later found that] the merge was done as a part of manual centralized forward ports in #3013

@mmusich @mtosi @VinInn @cerati @rovere @makortel
do you recall if this was discussed at some point in the past? I'm trying to understand if there was a partial recovery or if this was forgotten.

@mmasciov

[cmsbuild]

A new Issue was created by @slava77 Slava Krutelyov.

@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[makortel]

assign reconstruction

[cmsbuild]

New categories assigned: reconstruction

@mandrenguyen,@clacaputo you have been requested to review this Pull request/Issue and eventually sign? Thanks

[makortel]

I have no recollection (although what you describe rings some bell, but I don't remember what exactly).

[makortel]

This happened shortly after CMSSW_7_1_0_pre5 was made and does not show up in the following pre-release https://github.com/cms-sw/cmssw/releases/tag/CMSSW_7_1_0_pre6

I see this was done as part of #3013 (which technically is visible in the 7_1_0_pre6 release notes, but very easy to miss).

[slava77]

This happened shortly after CMSSW_7_1_0_pre5 was made and does not show up in the following pre-release https://github.com/cms-sw/cmssw/releases/tag/CMSSW_7_1_0_pre6

I see this was done as part of #3013 (which technically is visible in the 7_1_0_pre6 release notes, but very easy to miss).

Indeed, I eventually found it as well.

[VinInn]

No recollection what so ever (i mean was 9 years ago!)