-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup spurious change introduced in PAT photon/muon producer auto fwd-port in 2015 #41403
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41403/35269
|
A new Pull Request was created by @slava77 (Slava Krutelyov) for master. It involves the following packages:
@swertz, @vlimant, @clacaputo, @cmsbuild, @simonepigazzini, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
in the log I see Apparently something was merged that fails clang tests now; or there was an external dependency that's not recognized by the tests. the tests will need to be rerun after the next IB shows up |
Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9fbe84/32144/summary.html Comparison SummarySummary:
|
+1 |
+reconstruction |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
partly as a follow up to #41396 I was somewhat non-comprehensively looking at other changes from automatic forward ports
2315273#diff-2fdb475ba7d21b78d12e835c8df71fd7a251210fc88ebd4bc8ec6fd2b1dbb2c4L200-L201
was an auto-forward port of #10671 (75X) which in turn was a backport of #11140 (76X; initial version #10620) but there were enough nested merges and differences that the porting got apparently confused