-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hlttracking parabolic magnetic field in building and fitting #2291
hlttracking parabolic magnetic field in building and fitting #2291
Conversation
A new Pull Request was created by @mtosi (mia tosi) for CMSSW_7_1_X. hlttracking parabolic magnetic field in building and fitting It involves the following packages: Configuration/StandardSequences @nclopezo, @vlimant, @franzoni, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano, @davidlange6 can you please review it and eventually sign? Thanks. |
@@ -75,6 +75,10 @@ | |||
detIdsToDebug.push_back(0); | |||
detIdsToDebug.push_back(0); | |||
} | |||
if (cfg.exists("SimpleMagneticField")) { | |||
useSimpleMF = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bool useSimpleMF is never initialized (to false): please do it
…dRecord>().get(bfield) to get<IdealMagneticFieldRecord>().get(mfESInputTag, bfield) w/ mfESInputTag edm::ESInputTag which is constructed from the string parameter mfName. This parameter is set to "" as default value (in order to garuantee back-compatibility (i.e. standard magnetic field from DB) and it can be defined by config file as well
I've just update this pull request are now using the function where iTag is built w/ a string iName @cerati @rovere @perrotta @Martin-Grunewald @fwyzard @Dr15Jones |
-1 runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log ----- Begin Fatal Exception 12-Feb-2014 12:32:15 CET----------------------- An exception of category 'EventSetupWrongModule' occurred while [0] Processing run: 160960 [1] Calling beginRun for unscheduled module ConversionTrackCandidateProducer/'conversionTrackCandidates' [2] Using EventSetup component NavigationSchoolESProducer/'navigationSchoolESProducer' to make data NavigationSchool/'SimpleNavigationSchool' in record NavigationSchoolRecord Exception Message: EventSetup data was retrieved using an ESInputTag with the values moduleLabel = 'ParabolicMf' dataLabel = '' but the data matching the C++ class type and dataLabel comes from module type=AutoMagneticFieldESProducer label=''. Please either change the ESInputTag's 'module' label to be AutoMagneticFieldESProducer or add the EventSetup module ParabolicMf to the configuration. ----- End Fatal Exception ------------------------------------------------- 401.0 step1 runTheMatrix-results/401.0_TTbarNewMix+TTbarFSPU2+HARVESTFS/step1_TTbarNewMix+TTbarFSPU2+HARVESTFS.log ----- Begin Fatal Exception 12-Feb-2014 12:33:25 CET----------------------- An exception of category 'EventSetupWrongModule' occurred while [0] Processing run: 1 [1] Calling beginRun for unscheduled module EventSetupRecordDataGetter/'hltGetConditions' [2] Using EventSetup component CkfTrajectoryBuilderESProducer/'CkfTrajectoryBuilder' to make data TrajectoryBuilder/'CkfTrajectoryBuilder' in record CkfComponentsRecord [3] Using EventSetup component PropagatorWithMaterialESProducer/'MaterialPropagatorParabolicMF' to make data Propagator/'PropagatorWithMaterialParabolicMf' in record TrackingComponentsRecord Exception Message: EventSetup data was retrieved using an ESInputTag with the values moduleLabel = 'ParabolicMf' dataLabel = '' but the data matching the C++ class type and dataLabel comes from module type=VolumeBasedMagneticFieldESProducer label=''. Please either change the ESInputTag's 'module' label to be VolumeBasedMagneticFieldESProducer or add the EventSetup module ParabolicMf to the configuration. ----- End Fatal Exception ------------------------------------------------- 1000.0 step2 runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log ----- Begin Fatal Exception 12-Feb-2014 12:34:06 CET----------------------- An exception of category 'EventSetupWrongModule' occurred while [0] Processing run: 165121 [1] Calling beginRun for unscheduled module ConversionTrackCandidateProducer/'conversionTrackCandidates' [2] Using EventSetup component NavigationSchoolESProducer/'navigationSchoolESProducer' to make data NavigationSchool/'SimpleNavigationSchool' in record NavigationSchoolRecord Exception Message: EventSetup data was retrieved using an ESInputTag with the values moduleLabel = 'ParabolicMf' dataLabel = '' but the data matching the C++ class type and dataLabel comes from module type=AutoMagneticFieldESProducer label=''. Please either change the ESInputTag's 'module' label to be AutoMagneticFieldESProducer or add the EventSetup module ParabolicMf to the configuration. ----- End Fatal Exception ------------------------------------------------- 5.1 step1 runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log ----- Begin Fatal Exception 12-Feb-2014 12:33:12 CET----------------------- An exception of category 'EventSetupWrongModule' occurred while [0] Processing run: 1 [1] Calling beginRun for unscheduled module EventSetupRecordDataGetter/'hltGetConditions' [2] Using EventSetup component CkfTrajectoryBuilderESProducer/'CkfTrajectoryBuilder' to make data TrajectoryBuilder/'CkfTrajectoryBuilder' in record CkfComponentsRecord [3] Using EventSetup component PropagatorWithMaterialESProducer/'MaterialPropagatorParabolicMF' to make data Propagator/'PropagatorWithMaterialParabolicMf' in record TrackingComponentsRecord Exception Message: EventSetup data was retrieved using an ESInputTag with the values moduleLabel = 'ParabolicMf' dataLabel = '' but the data matching the C++ class type and dataLabel comes from module type=VolumeBasedMagneticFieldESProducer label=''. Please either change the ESInputTag's 'module' label to be VolumeBasedMagneticFieldESProducer or add the EventSetup module ParabolicMf to the configuration. ----- End Fatal Exception ------------------------------------------------- 1001.0 step2 runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log ----- Begin Fatal Exception 12-Feb-2014 12:36:31 CET----------------------- An exception of category 'EventSetupWrongModule' occurred while [0] Processing run: 165121 [1] Calling beginRun for unscheduled module ConversionTrackCandidateProducer/'conversionTrackCandidates' [2] Using EventSetup component NavigationSchoolESProducer/'navigationSchoolESProducer' to make data NavigationSchool/'SimpleNavigationSchool' in record NavigationSchoolRecord Exception Message: EventSetup data was retrieved using an ESInputTag with the values moduleLabel = 'ParabolicMf' dataLabel = '' but the data matching the C++ class type and dataLabel comes from module type=AutoMagneticFieldESProducer label=''. Please either change the ESInputTag's 'module' label to be AutoMagneticFieldESProducer or add the EventSetup module ParabolicMf to the configuration. ----- End Fatal Exception ------------------------------------------------- 1003.0 step2 runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log ----- Begin Fatal Exception 12-Feb-2014 12:36:32 CET----------------------- An exception of category 'EventSetupWrongModule' occurred while [0] Processing run: 191226 [1] Calling beginRun for unscheduled module ConversionTrackCandidateProducer/'conversionTrackCandidates' [2] Using EventSetup component NavigationSchoolESProducer/'navigationSchoolESProducer' to make data NavigationSchool/'SimpleNavigationSchool' in record NavigationSchoolRecord Exception Message: EventSetup data was retrieved using an ESInputTag with the values moduleLabel = 'ParabolicMf' dataLabel = '' but the data matching the C++ class type and dataLabel comes from module type=AutoMagneticFieldESProducer label=''. Please either change the ESInputTag's 'module' label to be AutoMagneticFieldESProducer or add the EventSetup module ParabolicMf to the configuration. ----- End Fatal Exception ------------------------------------------------- 8.0 step3 runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step3_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log ----- Begin Fatal Exception 12-Feb-2014 12:36:40 CET----------------------- An exception of category 'EventSetupWrongModule' occurred while [0] Processing run: 1 [1] Calling beginRun for unscheduled module ConversionTrackCandidateProducer/'conversionTrackCandidates' [2] Using EventSetup component NavigationSchoolESProducer/'navigationSchoolESProducer' to make data NavigationSchool/'SimpleNavigationSchool' in record NavigationSchoolRecord Exception Message: EventSetup data was retrieved using an ESInputTag with the values moduleLabel = 'ParabolicMf' dataLabel = '' but the data matching the C++ class type and dataLabel comes from module type=VolumeBasedMagneticFieldESProducer label=''. Please either change the ESInputTag's 'module' label to be VolumeBasedMagneticFieldESProducer or add the EventSetup module ParabolicMf to the configuration. ----- End Fatal Exception ------------------------------------------------- 1306.0 step3 runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log ----- Begin Fatal Exception 12-Feb-2014 12:38:15 CET----------------------- An exception of category 'EventSetupWrongModule' occurred while [0] Processing run: 1 [1] Calling beginRun for unscheduled module ConversionTrackCandidateProducer/'conversionTrackCandidates' [2] Using EventSetup component NavigationSchoolESProducer/'navigationSchoolESProducer' to make data NavigationSchool/'SimpleNavigationSchool' in record NavigationSchoolRecord Exception Message: EventSetup data was retrieved using an ESInputTag with the values moduleLabel = 'ParabolicMf' dataLabel = '' but the data matching the C++ class type and dataLabel comes from module type=VolumeBasedMagneticFieldESProducer label=''. Please either change the ESInputTag's 'module' label to be VolumeBasedMagneticFieldESProducer or add the EventSetup module ParabolicMf to the configuration. ----- End Fatal Exception ------------------------------------------------- 4.53 step3 runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log ----- Begin Fatal Exception 12-Feb-2014 12:38:43 CET----------------------- An exception of category 'EventSetupWrongModule' occurred while [0] Processing run: 194533 [1] Calling beginRun for unscheduled module ConversionTrackCandidateProducer/'conversionTrackCandidates' [2] Using EventSetup component NavigationSchoolESProducer/'navigationSchoolESProducer' to make data NavigationSchool/'SimpleNavigationSchool' in record NavigationSchoolRecord Exception Message: EventSetup data was retrieved using an ESInputTag with the values moduleLabel = 'ParabolicMf' dataLabel = '' but the data matching the C++ class type and dataLabel comes from module type=AutoMagneticFieldESProducer label=''. Please either change the ESInputTag's 'module' label to be AutoMagneticFieldESProducer or add the EventSetup module ParabolicMf to the configuration. ----- End Fatal Exception ------------------------------------------------- 25.0 step3 runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log ----- Begin Fatal Exception 12-Feb-2014 12:51:01 CET----------------------- An exception of category 'EventSetupWrongModule' occurred while [0] Processing run: 1 [1] Calling beginRun for unscheduled module ConversionTrackCandidateProducer/'conversionTrackCandidates' [2] Using EventSetup component NavigationSchoolESProducer/'navigationSchoolESProducer' to make data NavigationSchool/'SimpleNavigationSchool' in record NavigationSchoolRecord Exception Message: EventSetup data was retrieved using an ESInputTag with the values moduleLabel = 'ParabolicMf' dataLabel = '' but the data matching the C++ class type and dataLabel comes from module type=VolumeBasedMagneticFieldESProducer label=''. Please either change the ESInputTag's 'module' label to be VolumeBasedMagneticFieldESProducer or add the EventSetup module ParabolicMf to the configuration. ----- End Fatal Exception ------------------------------------------------- you can see the results of the tests here: |
…ionTrackCandidates (SimpleNavigationSchool) and hltGetConditions (MaterialPropagatorParabolicMF) )
I've just check, going back to string (and using the function EventSetupRecord::get(std::string& iTag, HolderT& iHolder) @perrotta @Martin-Grunewald @cerati @rovere @fwyzard @Dr15Jones |
@@ -52,7 +52,7 @@ void SeedFromProtoTrack::init(const reco::Track & proto, const edm::EventSetup& | |||
const Propagator* propagator = &(*propagatorHandle); | |||
|
|||
edm::ESHandle<MagneticField> field; | |||
es.get<IdealMagneticFieldRecord>().get(field); | |||
es.get<IdealMagneticFieldRecord>().get(field);//fixme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this "fixme" about?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it means that the (optional) simple magnetic field should also be added here but I could not find a simple way to propagate the pset to here (another possibility is to hardcode the name as done for the propagator but I don't like it)
+1 Testing #2291 48a9518 fwlite tests (validate.C)
DQM plots show results in agreement with above. More obvious is the increase in the duplicate rate near zero (matching the increase bump in general track yields; this is most visible in iter6) in samples with many tracks I suppose that by the next pre-release (or so) we will get an update to the duplicate merger. |
on timing, just to confirm the expected: there is a 5-10% reduction in CPU in *trackCandidates for general tracks iterations and for conversion tracks (based on TTBarPU wf 202.0 in 200 events) |
+1 |
…-parabolic-mf-build-fit Reco updates -- HLT Tracking parabolic magnetic field in building and fitting
I added the missing config file update
MagneticField_38T_PostLS1_cff.py
and now the error spotted in #2244 (comment)
seems to be fixed
1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED - time date Tue Feb 4 15:57:32 2014-date Tue Feb 4 15:45:01 2014; exit: 0 0 0 0
1 1 1 1 tests passed, 0 0 0 0 failed
@cerati @rovere @Martin-Grunewald @perrotta