Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add HL objects (towers, jets) #10213

Merged
merged 16 commits into from
Sep 17, 2015
Merged

add HL objects (towers, jets) #10213

merged 16 commits into from
Sep 17, 2015

Conversation

popovvp
Copy link
Contributor

@popovvp popovvp commented Jul 15, 2015

No description provided.

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Jul 15, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @popovvp for CMSSW_7_6_X.

add HL objects

It involves the following packages:

DQM/CastorMonitor

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Jul 17, 2015

@popovvp
this PR seems not mergeable. could you please rebase?
thanks,
F.

@vanbesien

@deguio
Copy link
Contributor

deguio commented Jul 20, 2015

-1

@deguio
Copy link
Contributor

deguio commented Jul 20, 2015

to be rebased

@popovvp
Merged 741tj from repository popovvp
97369fd 
Conflicts:
	DQM/CastorMonitor/src/CastorMonitorModule.cc

Replaced calls iEvent.getByLabel() with iEvent.getByToken()
@davidlange6
Copy link
Contributor

@cmsbuild, please test
there are commits here

@cmsbuild
Copy link
Contributor

+1
Tested at: 97369fd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10213/7428/summary.html

@cmsbuild
Copy link
Contributor

Pull request #10213 was updated. @danduggan, @deguio can you please check and sign again.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10213/7428/summary.html

@vanbesien
Copy link
Contributor

Checked: Comments #8910 (comment), #8807 (comment) and #7693 (comment) seem to have been handled now.

For the rest this PR is also okay for me.

@deguio
Copy link
Contributor

deguio commented Sep 11, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

@popovvp - for the record, what is HL stand for?

@popovvp
Copy link
Contributor Author

popovvp commented Sep 15, 2015

HL = High Level objects

On Tue, 15 Sep 2015, David Lange wrote:

@popovvp - for the record, what is HL stand for?

—
Reply to this email directly or view it on
GitHub.[AF7xzPYQ2zzoX_RsCaOGptmaRexFAjq1ks5oyCTpgaJpZM4FY9sK.gif]

@davidlange6
Copy link
Contributor

I guess you mean Castor HL objects - eg, rechits? can be good to have a more descriptive name in the title

@popovvp
Copy link
Contributor Author

popovvp commented Sep 17, 2015

High level objects taken from the next steps of analysis after
RecHits (towers, jets of different kinds, etc.)

@popovvp popovvp changed the title add HL objects add HL objects (towers, jets) Sep 17, 2015
@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 17, 2015
@cmsbuild
Merge pull request #10213 from popovvp/741tj
bd0a071 
add HL objects (towers, jets)
@cmsbuild cmsbuild merged commit bd0a071 into cms-sw:CMSSW_7_6_X Sep 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.
5 participants
@popovvp @cmsbuild @deguio @davidlange6 @vanbesien