Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jets, report str. #8807

Closed
wants to merge 7 commits into from
Closed

add jets, report str. #8807

wants to merge 7 commits into from

Conversation

popovvp
Copy link
Contributor

@popovvp popovvp commented Apr 21, 2015

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @popovvp for CMSSW_7_5_X.

add jets, report str.

It involves the following packages:

DQM/CastorMonitor

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Apr 23, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

-1
Tested at: 3b3b8e3
When I ran the RelVals I found an error in the following worklfows:
135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
----- Begin Fatal Exception 24-Apr-2015 11:40:46 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 1 event: 4
   [1] Running path 'HLT_IsoTkMu15_SaveObjects_v1'
   [2] Calling event method for module HLTTrackWithHits/'hltHighPtTkMu15TkFilt'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector
Looking for module label: hltIter2HighPtTkMuMerged
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8807/4381/summary.html

@vanbesien
Copy link
Contributor

@popovvp

See my comment in #7693:
As far as I can see, now there is only one histogram left with an unreasonably high amount of bins, namely the "hBunchOcc = ibooker.bookProfile(s,s,4000,0,4000, 100,0,1.e10,"");" here:
https://github.com/popovvp/cmssw/blob/750p2/DQM/CastorMonitor/src/CastorDigiMonitor.cc#L84

@deguio
Copy link
Contributor

deguio commented Apr 24, 2015

-1
rejecting for now. feel free to commit to the same branch to address @vanbesien comments
thanks,
F.

@davidlange6
Copy link
Contributor

closing as its rejected without response for a few weeks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants