Various improvements and small fixes of the MET uncertainty tools

[mmarionncern]

This PR contains several fixes, improvements and simplification of the MET uncertainty code and MET correction code. Also prepare the handling of the MVA MET uncertainties, planned for 76X.

Modified packages are :

• DataFormats/PatCandidates
• JetMETCorrections/Type1MET
• PhysicsTools/PatAlgos
• PhysicsTools/PatUtils

Code modifications :

• add the photon ES uncertainties in the pat::MET format, was missing before
• add automatic swich for JEC corrections betwee data and MC in the MET type1 code
• move to CHS jets and CHS JEC correctiosn for the type1 MET per default
• jet soft cleaning (electron/muon overlap removal) added per default in the uncertainty tool
• update of the XY MET shift correction (74X version, latest one)
• fix a bug in the XY MET shift correction computation
• update of the type0 correction (74X version, latest one)
• add shortcuts functions for the miniAOD production and re-production, with the minimal set of options needed by non-expert people.
• add example config file to show how to reprocess the MET on top of miniAODs

Expected changes :

• central MET value will change a bit due to the switch to CHS, no strong effect expected
• JES/JER MET uncertainties can change a bit due to the jet cleaning
• XY and T0 changes will affect all METs with at least one of those corrections

[cmsbuild]

A new Pull Request was created by @mmarionncern for CMSSW_7_5_X.

Various improvements and small fixes of the MET uncertainty tools

It involves the following packages:

DataFormats/PatCandidates
JetMETCorrections/Type1MET
PhysicsTools/PatAlgos
PhysicsTools/PatUtils

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @TaiSakuma, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[monttj]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

Pull request #10240 was updated. @cmsbuild, @vadler, @monttj can you please check and sign again.

[cmsbuild]

-1

Tested at: cf079fd
I found errors in the following unit tests:

---> test testJetMETCorrectionsType1MET had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10240/2837/summary.html

[cmsbuild]

Pull request #10240 was updated. @cmsbuild, @vadler, @danduggan, @deguio, @monttj can you please check and sign again.

[monttj]

+1

[deguio]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[deguio]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

+1
Tested at: aa33acd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10240/8087/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10240/8087/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1