Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various improvements and small fixes of the MET uncertainty tools 76X #10241

Merged
merged 20 commits into from
Sep 15, 2015
Merged

Various improvements and small fixes of the MET uncertainty tools 76X #10241

merged 20 commits into from
Sep 15, 2015

Conversation

mmarionncern
Copy link

Same as #10240 for 76X

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Jul 16, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmarionncern for CMSSW_7_6_X.

Various improvements and small fixes of the MET uncertainty tools 76X

It involves the following packages:

DataFormats/PatCandidates
JetMETCorrections/Type1MET
PhysicsTools/PatAlgos
PhysicsTools/PatUtils

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @TaiSakuma, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@monttj
Copy link
Contributor

monttj commented Aug 5, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

Pull request #10241 was updated. @cmsbuild, @vadler, @monttj can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

-1

Tested at: f416960
I found errors in the following unit tests:

---> test testJetMETCorrectionsType1MET had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10241/6991/summary.html

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@monttj
Copy link
Contributor

monttj commented Aug 20, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #10241 was updated. @cmsbuild, @vadler, @danduggan, @deguio, @monttj can you please check and sign again.

@cmsbuild
Copy link
Contributor

-1
@mmarionncern This pull request cannot be automatically merged, could you please rebase it?
you can see the log for git cms-merge-topic here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10241/7518/git-merge-result

matthieu added 2 commits August 28, 2015 09:45
fix thread safety, and condition reading from DB
552e03c 
Conflicts:
	JetMETCorrections/Type1MET/plugins/MultShiftMETcorrInputProducer.cc
	JetMETCorrections/Type1MET/plugins/MultShiftMETcorrInputProducer.h
last fix on the XY shift correcton producer
aa33acd 
Conflicts:
	JetMETCorrections/Type1MET/plugins/MultShiftMETcorrInputProducer.cc
@deguio
Copy link
Contributor

deguio commented Sep 1, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2015

Pull request #10241 was updated. @cmsbuild, @vadler, @danduggan, @deguio, @monttj can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2015

+1
Tested at: aa33acd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10241/7791/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10241/7791/summary.html

@monttj
Copy link
Contributor

monttj commented Sep 3, 2015

+1
approved already for 75X

@deguio
Copy link
Contributor

deguio commented Sep 14, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 15, 2015
@cmsbuild
Merge pull request #10241 from cms-met/METCorTool75X-071515
e3ad181 
Various improvements and small fixes of the MET uncertainty tools 76X
@cmsbuild cmsbuild merged commit e3ad181 into cms-sw:CMSSW_7_6_X Sep 15, 2015
@mmarionncern mmarionncern deleted the METCorTool75X-071515 branch November 14, 2016 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved comparison-available dqm-approved fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.
7 participants
@mmarionncern @cmsbuild @monttj @davidlange6 @danduggan @deguio @schoef