Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factorise PreSplitting configuration from InitialStep #10583

Merged
merged 1 commit into from
Sep 17, 2015
Merged

Factorise PreSplitting configuration from InitialStep #10583

merged 1 commit into from
Sep 17, 2015

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Aug 5, 2015

Completely factorize PreSplitting from InitialStep configuration, so that they can be tuned independently. Fix order of python import logic. No regression expected.

See also #10580

@rovere
Completely factorize PreSplitting from InitialStep configuration, so …
a49367c 
…that they can be tuned independently. Fix order of python import logic. No regression expected.
@rovere rovere mentioned this pull request Aug 5, 2015
Merged
@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Aug 5, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

A new Pull Request was created by @rovere (Marco Rovere) for CMSSW_7_4_X.

Factorise PreSplitting configuration from InitialStep

It involves the following packages:

RecoTracker/IterativeTracking

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @VinInn, @mschrode, @istaslis, @gpetruc, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Aug 5, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

-1
Tested at: a49367c
When I ran the RelVals I found an error in the following worklfows:
135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
----- Begin Fatal Exception 05-Aug-2015 15:23:18 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
Exception Message:
unable to load /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_4_X_2015-08-05-1100/lib/slc6_amd64_gcc491/poisoned/plugin-poisoned-DQMHLTEvFPlugins.so because /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_4_X_2015-08-05-1100/lib/slc6_amd64_gcc491/poisoned/plugin-poisoned-DQMHLTEvFPlugins.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
----- Begin Fatal Exception 05-Aug-2015 15:27:12 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
Exception Message:
unable to load /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_4_X_2015-08-05-1100/lib/slc6_amd64_gcc491/poisoned/plugin-poisoned-DQMHLTEvFPlugins.so because /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_4_X_2015-08-05-1100/lib/slc6_amd64_gcc491/poisoned/plugin-poisoned-DQMHLTEvFPlugins.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaEle+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaEle+HARVEST+ALCATT.log
----- Begin Fatal Exception 05-Aug-2015 15:28:31 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
Exception Message:
unable to load /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_4_X_2015-08-05-1100/lib/slc6_amd64_gcc491/poisoned/plugin-poisoned-DQMHLTEvFPlugins.so because /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_4_X_2015-08-05-1100/lib/slc6_amd64_gcc491/poisoned/plugin-poisoned-DQMHLTEvFPlugins.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 05-Aug-2015 15:29:01 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
Exception Message:
unable to load /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_4_X_2015-08-05-1100/lib/slc6_amd64_gcc491/poisoned/plugin-poisoned-DQMHLTEvFPlugins.so because /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_4_X_2015-08-05-1100/lib/slc6_amd64_gcc491/poisoned/plugin-poisoned-DQMHLTEvFPlugins.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------

1330.0 step2

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 05-Aug-2015 15:33:36 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
Exception Message:
unable to load /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_4_X_2015-08-05-1100/lib/slc6_amd64_gcc491/poisoned/plugin-poisoned-DQMHLTEvFPlugins.so because /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_4_X_2015-08-05-1100/lib/slc6_amd64_gcc491/poisoned/plugin-poisoned-DQMHLTEvFPlugins.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3.log
----- Begin Fatal Exception 05-Aug-2015 15:35:12 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
Exception Message:
unable to load /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_4_X_2015-08-05-1100/lib/slc6_amd64_gcc491/poisoned/plugin-poisoned-DQMHLTEvFPlugins.so because /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_4_X_2015-08-05-1100/lib/slc6_amd64_gcc491/poisoned/plugin-poisoned-DQMHLTEvFPlugins.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 05-Aug-2015 15:38:55 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
Exception Message:
unable to load /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_4_X_2015-08-05-1100/lib/slc6_amd64_gcc491/poisoned/plugin-poisoned-DQMHLTEvFPlugins.so because /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_4_X_2015-08-05-1100/lib/slc6_amd64_gcc491/poisoned/plugin-poisoned-DQMHLTEvFPlugins.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------

50202.0 step2

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
----- Begin Fatal Exception 05-Aug-2015 15:40:13 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
Exception Message:
unable to load /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_4_X_2015-08-05-1100/lib/slc6_amd64_gcc491/poisoned/plugin-poisoned-DQMHLTEvFPlugins.so because /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_4_X_2015-08-05-1100/lib/slc6_amd64_gcc491/poisoned/plugin-poisoned-DQMHLTEvFPlugins.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10583/6986/summary.html

@slava77
Copy link
Contributor

slava77 commented Aug 5, 2015

@smuzaffar is this a broken IB as well?
Changes in this PR are not compatible with the errors.

@davidlange6
Copy link
Contributor

yes, fallout from the duplicate plugins

On Aug 5, 2015, at 5:18 PM, Slava Krutelyov [email protected] wrote:

@smuzaffar is this a broken IB as well?
Changes in this PR are not compatible with the errors.

—
Reply to this email directly or view it on GitHub.

@smuzaffar
Copy link
Contributor

yes it is a broken IB.
13h00 IB is being build to fix this.

@slava77
Copy link
Contributor

slava77 commented Aug 6, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

+1
Tested at: a49367c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10583/193747/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10583/193747/summary.html

@cvuosalo
Copy link
Contributor

cvuosalo commented Aug 8, 2015

+1

For #10583 a49367c

For Tracking, factorizing PreSplitting configuration from the InitialStep. This code improvement to facilitate tuning should have no effect on monitored quantities. The 76X version of this PR, #10580, has already been approved by Reco.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_4_X_2015-08-05-2300 show no significant differences, as expected. Correct inclusion of the code change into the config was verified for #10580.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@slava77
Copy link
Contributor

slava77 commented Aug 31, 2015

@rovere @VinInn
is this PR essential for 74X or 75X?

@rovere
Copy link
Contributor Author

rovere commented Sep 1, 2015

@slava77
strictly speaking it is not essential, but nice to have. Not a big deal if it's not either.

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 17, 2015
@cmsbuild
Merge pull request #10583 from rovere/FactorizePreSplittingAndChi2Mes…
1729684 
…Estimator_74X

Factorise PreSplitting configuration from InitialStep
@cmsbuild cmsbuild merged commit 1729684 into cms-sw:CMSSW_7_4_X Sep 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed reconstruction-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.
6 participants
@rovere @cmsbuild @slava77 @davidlange6 @smuzaffar @cvuosalo