-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factorise PreSplitting configuration from InitialStep #10584
Factorise PreSplitting configuration from InitialStep #10584
Conversation
…that they can be tuned independently. Fix order of python import logic. No regression expected.
A new Pull Request was created by @rovere (Marco Rovere) for CMSSW_7_5_X. Factorise PreSplitting configuration from InitialStep It involves the following packages: RecoTracker/IterativeTracking @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 For Tracking, factorizing PreSplitting configuration from the InitialStep. This code improvement to facilitate tuning should have no effect on monitored quantities. The 74X and 76X versions of this PR, #10583 and #10580, have already been approved by Reco. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-08-05-1100 show no significant differences, as expected. Correct inclusion of the code change into the config was verified for #10580. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
…Estimator_75X Factorise PreSplitting configuration from InitialStep
Completely factorize PreSplitting from InitialStep configuration, so that they can be tuned independently. Fix order of python import logic. No regression expected.
See also #10580 e #10583