MET Filter update (port of #10604)

[schoef]

Please see #10604

[cmsbuild]

A new Pull Request was created by @schoef for CMSSW_7_6_X.

MET Filter update (port of #10604)

It involves the following packages:

CalibMuon/DTCalibration
CommonTools/RecoAlgos
PhysicsTools/PatAlgos
RecoMET/METFilters

@diguida, @cvuosalo, @cerminar, @monttj, @cmsbuild, @slava77, @vadler, @mmusich can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @imarches, @makortel, @acaudron, @abbiendi, @mmarionncern, @jhgoh, @ahinzmann, @nhanvtran, @ferencek, @gpetruc, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

-1
Tested at: 1d4c2b9
I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 8 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/cms/cmssw/CMSSW_7_6_X_2015-08-06-1100/src/CommonTools/Utils/src/ExpressionSetter.h:2:9: note: 'CommoTools_Utils_ExpressionSetter_h' is defined here; did you mean 'CommonTools_Utils_ExpressionSetter_h'?
#define CommoTools_Utils_ExpressionSetter_h
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        CommonTools_Utils_ExpressionSetter_h
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-08-06-1100/src/Fireworks/Core/src/FWGlimpseView.cc 
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-08-06-1100/src/Fireworks/Core/src/FWGUIManager.cc:664:70: error: expression result unused [-Werror,-Wunused-value]
         parse("theta()", grammar.use_parser<1>() >> end_p, space_p).full;
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-08-06-1100/src/Fireworks/Core/src/FWGUIManager.cc:666:68: error: expression result unused [-Werror,-Wunused-value]
         parse("phi()", grammar.use_parser<1>() >> end_p, space_p).full;
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10609/7027/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
320f27c
c068edd
3e9163f
9be7629
3e64cfe
d529037
b213fc1
37e6bec
e2b3b14
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10609/7027/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10609/7027/git-merge-result

[schoef]

@slava77 The 'ProductNotFound' seems not related to the PR.
Let me know if smth is needed from my side.

[slava77]

Robert,
no requests from me (RECO).
AlCa and AT signatures are still pending

[slava77]

@monttj @mmusich @diguida
please check this one as well
Thank you

[monttj]

+1
This is 76X version for #10604 which is already approved.

[mmusich]

+1
clean up of ALCARECODtCalibHI and ALCARECODtCalib configurations.
76X version for #10604 which is already approved.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[mmusich]

please test
let's see if the error disappears on a more recent IB

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

-1

Tested at: 1d4c2b9
I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10609/7413/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10609/7413/summary.html