Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new primary vertex filter in hotline and high MET skim #11060

Merged
merged 1 commit into from
Oct 29, 2015
Merged

Use new primary vertex filter in hotline and high MET skim #11060

merged 1 commit into from
Oct 29, 2015

Conversation

duanders
Copy link
Contributor

@duanders duanders commented Sep 1, 2015

Switch to the new primary vertex filter introduced in #10609.

@schoef

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2015

A new Pull Request was created by @duanders (Dustin Anderson) for CMSSW_7_6_X.

Use new primary vertex filter in hotline and high MET skim

It involves the following packages:

Calibration/Hotline
DPGAnalysis/Skims

@diguida, @boudoul, @franzoni, @cerminar, @cmsbuild, @srimanob, @mmusich can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Sep 1, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2015

-1
Tested at: 4602c0a
When I ran the RelVals I found an error in the following worklfows:
4.53 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11060/7777/summary.html

@duanders
Copy link
Contributor Author

duanders commented Sep 3, 2015

@mmusich Can we please have a re-test?

@mmusich
Copy link
Contributor

mmusich commented Sep 3, 2015

please test
@duanders sorry, slipped out of my attention

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

The jenkins tests job failed, please try again.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/7872/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

@mmusich
Copy link
Contributor

mmusich commented Sep 10, 2015

+1
for https://github.com/duanders/cmssw/commit/4602c0aa6665ef83e0c54a1d68871db3005a6b59
Introducing new primary vertex filter in hotline

@mariadalfonso
Copy link
Contributor

@srimanob please have a look at this PR.
The equivalent 74 is already fully signed #11220,
would like to have this asap in the 3.8 T runs

@fabozzi
Copy link
Contributor

fabozzi commented Oct 27, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 29, 2015
Use new primary vertex filter in hotline and high MET skim
@cmsbuild cmsbuild merged commit 0470aa9 into cms-sw:CMSSW_7_6_X Oct 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants