Convert all remaining RECO & MiniAOD modules that are executed to threaded FW (74X)

[lgray]

Backport of #11140

@Dr15Jones 74X has an older version of tbb so I had to use insert rather than emplace. It seems like the return value is exactly the same as for emplace, so the code change is trivial.

[cmsbuild]

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_4_X.

Convert all remaining MiniAOD modules to threaded FW (74X)

It involves the following packages:

CommonTools/ParticleFlow
CommonTools/RecoAlgos
CommonTools/RecoUtils
CommonTools/UtilAlgos
CommonTools/Utils
DataFormats/PatCandidates
JetMETCorrections/Type1MET
PhysicsTools/HepMCCandAlgos
PhysicsTools/JetCharge
PhysicsTools/JetMCAlgos
PhysicsTools/PatAlgos
PhysicsTools/PatUtils
RecoEgamma/EgammaPhotonProducers
RecoJets/JetProducers

@cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @Sam-Harper, @jdolen, @imarches, @makortel, @acaudron, @abbiendi, @mmarionncern, @jhgoh, @ahinzmann, @nhanvtran, @yslai, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 3f21ae6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10673/7125/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10673/7125/summary.html

[slava77]

I think this PR should be merged only after all currently pending re-miniAOD PRs are merged.
Please check if this PR merges on top of #10649
Thanks.

[lgray]

@slava77 indeed for now this does not merge with #10649. Looks like PATCandidateProducer is getting updated to the version in 75/76. I'll leave the PR here as a placeholder, we can return to it once the dust is settled.

[lgray]

@slaba77 looking at the changes that come, it's not 75/76 changes but some other new addition. Anyway it is a straightforward adaptation.

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

Pull request #10673 was updated. @cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please check and sign again.

[cmsbuild]

The tests are being triggered in jenkins.

[lgray]

@monttj @mulhearn please resign this PR. Thanks!

[cmsbuild]

+1
Tested at: e5f214c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10673/8013/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10673/8013/summary.html

[monttj]

+1

[lgray]

@mulhearn please sign, thanks.

[cvuosalo]

+1

For #10673 e5f214c

Convert remaining legacy modules in RECO to support multi-threading. There should be no change in monitored quantities. #11140 is the 76X version of this PR, and it has already been merged. #10671 is the 75X version, and it has already been approved by Reco.

Jenkins tests against baseline CMSSW_7_4_X_2015-09-08-2300 show no significant differences, as expected. See #10806 for information about the performance of this PR.

[lgray]

@mulhearn please sign. thanks!

[mulhearn]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1