Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multithreading fix for 74x: L1TCaloUpgradeToGCTConverter #11356

Closed
wants to merge 1 commit into from
Closed

multithreading fix for 74x: L1TCaloUpgradeToGCTConverter #11356

wants to merge 1 commit into from

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Sep 18, 2015

  • change all configuration parameters into const members
  • initialise them in the member initializer list
  • remove unused methods and member variables
  • remove "using namespace" from header file
  • change into a global::EDProducer

@fwyzard
L1TCaloUpgradeToGCTConverter: change into a global::EDProducer
24eb8b0 
  - change all configuration parameters into const members
  - initialise them in the member initializer list
  - remove unused methods and member variables
  - remove "using namespace" from header file
  - change into a global::EDProducer
@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 18, 2015

tracked at #11317

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Sep 18, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_4_X.

L1TCaloUpgradeToGCTConverter: change into a global::EDProducer

It involves the following packages:

L1Trigger/L1TCalorimeter

@cmsbuild, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 18, 2015

this seems to have been fixed independently by 6beb6ca from #10673

@fwyzard fwyzard closed this Sep 18, 2015
@fwyzard fwyzard mentioned this pull request Sep 21, 2015
Closed
@fwyzard fwyzard changed the title L1TCaloUpgradeToGCTConverter: change into a global::EDProducer multithreading fix for 74x: L1TCaloUpgradeToGCTConverter Sep 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending l1-pending orp-pending pending-signatures tests-pending
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.
2 participants
@fwyzard @cmsbuild