-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifier to apply energy corrections to photons and electrons (miniAOD) for 76X #10689
Modifier to apply energy corrections to photons and electrons (miniAOD) for 76X #10689
Conversation
A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_6_X. Modifier to apply energy corrections to photons and electrons (miniAOD) for 76X It involves the following packages: PhysicsTools/PatAlgos @cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
@slava77 Apologies, these tests will fail. Some commits weren't pushed. |
-1 runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log 8.0 step1 runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step1_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log 9.0 step1 runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step1_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log 25.0 step1 runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step1_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log 135.4 step1 runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log 1306.0 step1 runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step1_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log 1330.0 step1 runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step1_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log 101.0 step1 runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log 25202.0 step1 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step1_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log 50202.0 step1 runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step1_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log 4.22 step1 DAS Error 4.53 step1 DAS Error 140.53 step1 DAS Error 1000.0 step1 DAS Error 1001.0 step1 DAS Error 1003.0 step1 DAS Error you can see the results of the tests here: |
96fcf41
to
c2dae70
Compare
@cmsbuild please test |
The tests are being triggered in jenkins. |
writeValueMap(iEvent, src, eleIEta ,eleIEta_); | ||
writeValueMap(iEvent, src, eleCryPhi ,eleCryPhi_); | ||
writeValueMap(iEvent, src, eleCryEta ,eleCryEta_); | ||
lazyTools.reset(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this really do anything useful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Frees memory between events.
-1 Tested at: e9ad0ce ---> test runtestPhysicsToolsPatAlgos had ERRORS you can see the results of the tests here: |
clusterDPhiToSeed2, | ||
clusterDEtaToSeed0, | ||
clusterDEtaToSeed1, | ||
clusterDEtaToSeed2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, the unyielding desire to copy-paste.
To change this list, there are 8 places to edit.
😱
+1
the wishlist for the future:
|
Z mass? |
Big shifts can happen in this case since tails aren't getting pulled up by regressing to the mean. |
On 8/20/15 5:09 PM, Lindsey Gray wrote:
Sure, once somebody puts it in the miniADO DQM sequence
|
ok On Fri, Aug 21, 2015 at 12:20 AM, Slava Krutelyov [email protected]
|
@slava77 double checked the z-peak in 200 ZEE PU35@25ns, using veto working point and taking two highest energy electrons. The improvement in the momentum resolution is obvious even with (the same) 66 events. The new RMS is 5.65 GeV. |
@monttj |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
Hi Tae Jeong, Yes, the next iteration of these corrections will be applied at RECO level. -L On Fri, Aug 21, 2015 at 6:47 PM, Tae Jeong Kim [email protected]
|
Modifier to apply energy corrections to photons and electrons (miniAOD) for 76X
Like #10690 but for 76X. Implements most of the comments from Slava on the 75X version.
Payloads for GT have been queued for integration.
Supersedes #10650