Modifier to apply energy corrections to photons and electrons (miniAOD) for 75X

[lgray]

This PR implements the latest energy corrections for GED electrons and photons and applies them during MiniAOD processing.

ECAL regressions are done using GBRLikelihood and a good boost in resolution is expected compared to the previous BDTs.
The track + ECAL combination is done with a standard BDT, but the inputs are updated to use the semi-parametric BDT output.

The ES Prefers will removed once the weights will be integrated into the GT.
Working on comparison plots for the resolution.

Supersedes #10611

[cmsbuild]

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_5_X.

Modifier to apply energy corrections to photons and electrons (miniAOD)

It involves the following packages:

PhysicsTools/PatAlgos
RecoEgamma/EgammaPhotonProducers
RecoEgamma/EgammaTools
RecoEgamma/ElectronIdentification
RecoEgamma/PhotonIdentification

@cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @Sam-Harper, @imarches, @ahinzmann, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@lgray the description is outdated by now (ref files are never more; the payloads are in the DB now; the GT is still not available though)

[lgray]

@slava77 done.

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 8c5cd8d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10690/7157/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10690/7157/summary.html

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 4b5cd3b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10690/7581/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10690/7581/summary.html

[lgray]

@mmusich @diguida could you please resign? Thanks!

[slava77]

+1

for #10690 4b5cd3b

• changes in the code since the last signoff (lgray/cmssw@4cc7bf1...4b5cd3b) are the same as Change photon & electron regressions back to fractionized shower shapes  #10921 0c57abf
• jenkins tests passed
  • ... not many comparisons made it to the comparisons results
  • the ones that made it show differences only in miniAOD DQM, showing an effect of now applied corrections (similar to what was posted here earlier)
• tested locally in CMSSW_7_5_X_2015-08-20-2300 /test area sign580/, comparing specifically with respect to the last iteration in Modifier to apply energy corrections to photons and electrons (miniAOD) for 75X #10690 4cc7bf1
  • there are minor changes in the electron miniAOD DQM observables (photons should be changing as well, but they are not monitored). E.g. in 251721 DoubleEG over 200 events (left/black is 4cc7bf1, right/red is 4b5cd3b)
    
    

[slava77]

@monttj
please re-sign if there are no issues
Thanks

[monttj]

+1

[mmusich]

+1
for lgray@4cc7bf1

[mmusich]

@lgray the bot doesn't seem to react to any of my actions....

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[lgray]

Sometimes the bot is asleep.

FYI I am in Japan on vacation, my personal response will also be very
limited from now on.

(Sent from my Nexus 6)
On Aug 25, 2015 8:26 PM, "cmsbuild" [email protected] wrote:

This pull request is fully signed and it will be integrated in one of the
next CMSSW_7_5_X IBs once checked with relvals in the development release
cycle of CMSSW (tests are also fine). This pull request requires discussion
in the ORP meeting before it's merged. @davidlange6
https://github.com/davidlange6, @Degano https://github.com/degano,
@smuzaffar https://github.com/smuzaffar

—
Reply to this email directly or view it on GitHub
#10690 (comment).

[smuzaffar]

GitHub was under DDos attack yesterday and that is why cms-bot was not able to process your comments

[davidlange6]

+1