Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make surface deformation plots much faster #11022

Merged
merged 10 commits into from
Sep 18, 2015
Merged

Make surface deformation plots much faster #11022

merged 10 commits into from
Sep 18, 2015

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented Aug 28, 2015

The time it takes to run the validation itself does not change noticeably. The time it takes to make the plots decreases by a lot (<1 minute per curve, down from >~10 minutes per curve). The plots themselves are identical to before.

Also some cleanup of unused templates in alternateValidationTemplates, without losing any functionality.

hroskes added 7 commits August 28, 2015 21:59
@hroskes
Add summary profiles
09da8de
@hroskes
Surface deformations for cosmics at 0T
df976b6
@hroskes
Use new profiles to create surface deformation plots
91d21b4
@hroskes
Save offline validation plots as png, eps, pdf, root
f63d877
@hroskes
Remove two unnecessary templates:
09f5050 
- CosmicsOfflineValidation_Deformations can already be done (and is done) in other ways
- add an option to mimic the primary part of yResidualsOfflineValidation; the rest appears to be specific to a long time ago
@hroskes
Since it's so fast there is now no reason not to make surface deforma…
53132ac 
…tion plots by default
@hroskes
Remove another unused template
e4a5103
This was referenced Aug 28, 2015
Merged
Merged
@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Aug 28, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_7_6_X.

Make surface deformation plots much faster

It involves the following packages:

Alignment/OfflineValidation

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @frmeier, @mmusich, @tlampen this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #11022 was updated. @cmsbuild, @mmusich, @diguida, @cerminar can you please check and sign again.

@hroskes hroskes mentioned this pull request Aug 30, 2015
Merged
@mmusich
Copy link
Contributor

mmusich commented Aug 31, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: f449dd8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11022/7746/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11022/7746/summary.html

@hroskes hroskes mentioned this pull request Sep 6, 2015
Merged
@hroskes
Copy link
Contributor Author

hroskes commented Sep 17, 2015

@cmsbuild sorry, I found a bug

@cmsbuild
Copy link
Contributor

Pull request #11022 was updated. @cmsbuild, @mmusich, @diguida, @cerminar can you please check and sign again.

@diguida
Copy link
Contributor

diguida commented Sep 17, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: cda417c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11022/8180/summary.html

@diguida
Copy link
Contributor

diguida commented Sep 17, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11022/8180/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 18, 2015
@cmsbuild
Merge pull request #11022 from hroskes/faster-surface-shapes-76X
846734d 
Make surface deformation plots much faster
@cmsbuild cmsbuild merged commit 846734d into cms-sw:CMSSW_7_6_X Sep 18, 2015
@hroskes hroskes deleted the faster-surface-shapes-76X branch September 18, 2015 14:59
cmsbuild added a commit that referenced this pull request Nov 4, 2015
@cmsbuild
Merge pull request #11023 from hroskes/faster-surface-shapes-75X
0fa6a68 
Backport of #11022: Make surface deformation plots much faster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved comparison-available fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.
5 participants
@hroskes @cmsbuild @mmusich @diguida @davidlange6