-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finally fix segfault! #11162
Finally fix segfault! #11162
Conversation
A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_7_6_X. Finally fix segfault! It involves the following packages: Alignment/OfflineValidation @cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
See details here: #6085
This fixes the segfault, and I think it addresses everyone's concerns there. Please let me know if not.
The summary histograms and the tree are filled in the endJob, as before, because they require the lower level histograms to be completely filled first, and it would be inefficient to reset every run. However, the structure (e.g. which histograms summarize which other histograms), which comes from the tracker topology, is set up at the beginning. In my tests I find identical output to setting the lastSetup variable.
This is orthogonal to #11022 except for one commit, which is rebased here to avoid conflicts.