-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamer output modules ported to one::OutputModule (75X) #11116
Streamer output modules ported to one::OutputModule (75X) #11116
Conversation
A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_7_5_X. Streamer output modules ported to one::OutputModule (75X) It involves the following packages: EventFilter/Utilities @smuzaffar, @Dr15Jones, @cvuosalo, @emeschi, @cmsbuild, @slava77, @mommsen can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
-1 >> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_5_X_2015-09-02-1100/src/DQMServices/StreamerIO/plugins/TriggerSelector.cc >> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_5_X_2015-09-02-1100/src/DQMServices/StreamerIO/test/DQMStreamerOutputModule.cc >> Building shared library tmp/slc6_amd64_gcc491/src/EventFilter/Utilities/src/EventFilterUtilities/libEventFilterUtilities.so >> Building shared library tmp/slc6_amd64_gcc491/src/FWCore/Version/src/FWCoreVersion/libFWCoreVersion.so /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_5_X_2015-09-02-1100/src/DQMServices/StreamerIO/test/DQMStreamerOutputModule.cc: In constructor 'edm::DQMStreamerOutputModule::DQMStreamerOutputModule(const edm::ParameterSet&)': /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_5_X_2015-09-02-1100/src/DQMServices/StreamerIO/test/DQMStreamerOutputModule.cc:65:20: error: no matching function for call to 'edm::one::OutputModuleBase::OutputModuleBase()' currentRun_(0) { ^ /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_5_X_2015-09-02-1100/src/DQMServices/StreamerIO/test/DQMStreamerOutputModule.cc:65:20: note: candidate is: In file included from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_5_X_2015-09-02-1100/src/FWCore/Framework/interface/one/outputmoduleAbilityToImplementor.h:27:0, from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_5_X_2015-09-02-1100/src/FWCore/Framework/interface/one/OutputModule.h:24, you can see the results of the tests here: |
Pull request #11116 was updated. @smuzaffar, @Dr15Jones, @cvuosalo, @emeschi, @cmsbuild, @deguio, @slava77, @mommsen, @danduggan can you please check and sign again. |
Please test |
The tests are being triggered in jenkins. |
+1 |
+1 |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Streamer output modules ported to one::OutputModule (75X)
Migrates EvFOutputModule (DAQ) and EventStreamFileWriter from legacy to one::OutputModule interface
Backport of #11115 that is against 7_6_X