Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamer output modules ported to one::OutputModule (75X) #11116

Merged
merged 5 commits into from
Sep 15, 2015

Conversation

smorovic
Copy link
Contributor

@smorovic smorovic commented Sep 3, 2015

Migrates EvFOutputModule (DAQ) and EventStreamFileWriter from legacy to one::OutputModule interface
Backport of #11115 that is against 7_6_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_7_5_X.

Streamer output modules ported to one::OutputModule (75X)

It involves the following packages:

EventFilter/Utilities
IOPool/Streamer

@smuzaffar, @Dr15Jones, @cvuosalo, @emeschi, @cmsbuild, @slava77, @mommsen can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cvuosalo
Copy link
Contributor

cvuosalo commented Sep 3, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

-1
Tested at: aeb7c8b
I found an error when building:

>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_5_X_2015-09-02-1100/src/DQMServices/StreamerIO/plugins/TriggerSelector.cc 
>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_5_X_2015-09-02-1100/src/DQMServices/StreamerIO/test/DQMStreamerOutputModule.cc 
>> Building shared library tmp/slc6_amd64_gcc491/src/EventFilter/Utilities/src/EventFilterUtilities/libEventFilterUtilities.so
>> Building shared library tmp/slc6_amd64_gcc491/src/FWCore/Version/src/FWCoreVersion/libFWCoreVersion.so
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_5_X_2015-09-02-1100/src/DQMServices/StreamerIO/test/DQMStreamerOutputModule.cc: In constructor 'edm::DQMStreamerOutputModule::DQMStreamerOutputModule(const edm::ParameterSet&)':
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_5_X_2015-09-02-1100/src/DQMServices/StreamerIO/test/DQMStreamerOutputModule.cc:65:20: error: no matching function for call to 'edm::one::OutputModuleBase::OutputModuleBase()'
       currentRun_(0) {
                    ^
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_5_X_2015-09-02-1100/src/DQMServices/StreamerIO/test/DQMStreamerOutputModule.cc:65:20: note: candidate is:
In file included from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_5_X_2015-09-02-1100/src/FWCore/Framework/interface/one/outputmoduleAbilityToImplementor.h:27:0,
                 from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_5_X_2015-09-02-1100/src/FWCore/Framework/interface/one/OutputModule.h:24,


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11116/7881/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

Pull request #11116 was updated. @smuzaffar, @Dr15Jones, @cvuosalo, @emeschi, @cmsbuild, @deguio, @slava77, @mommsen, @danduggan can you please check and sign again.

@Dr15Jones
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2015

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2015

@cvuosalo
Copy link
Contributor

cvuosalo commented Sep 8, 2015

+1

For #11116 8916c51

Second approval after rebasing. Jenkins tests against baseline CMSSW_7_5_X_2015-09-06-2300 show no significant differences, as before.

@Dr15Jones
Copy link
Contributor

+1

@deguio
Copy link
Contributor

deguio commented Sep 11, 2015

+1

@emeschi
Copy link
Contributor

emeschi commented Sep 14, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 15, 2015
Streamer output modules ported to one::OutputModule (75X)
@cmsbuild cmsbuild merged commit 72ecc3d into cms-sw:CMSSW_7_5_X Sep 15, 2015
@smorovic smorovic deleted the one-StreamerOutputModule-75X branch September 23, 2015 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants