Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamer output modules ported to one::OutputModule (74X) #11245

Merged
merged 5 commits into from
Sep 17, 2015
Merged

Streamer output modules ported to one::OutputModule (74X) #11245

merged 5 commits into from
Sep 17, 2015

Conversation

smorovic
Copy link
Contributor

Migrates EvFOutputModule (DAQ) and EventStreamFileWriter from legacy to one::OutputModule interface
Backport of #11115 and #11116 in 76X and 75X

@smorovic
port of StreamerOutputModuleBase to one::OutputModule base class
e52956b 
Backports parts of this commit from 76X branch:
cms-sw@a4b465d
@smorovic
changes suggested by Dr15Jones: more appropriate one::OutputModule
a0840cc 
template, and adding override
@smorovic
*using template in form one::OutputModule<one::WatchRuns,one::WatchLu…
3a2603a 
…minosityBlocks> is needed to compile (in analogy to PoolOutputModule)

*streamer output module now also needs beginLumi and endLumi handlers
@smorovic
override beginJob
7d0a755
@smorovic
fix compilation of DQMStreamerOutputModules, update to one::OutputModule
caed04f
@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Sep 14, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_7_4_X.

Streamer output modules ported to one::OutputModule (75X)

It involves the following packages:

DQMServices/StreamerIO
EventFilter/Utilities
IOPool/Streamer

@smuzaffar, @Dr15Jones, @cvuosalo, @emeschi, @cmsbuild, @deguio, @slava77, @mommsen, @danduggan can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @barvic, @wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

please test

@smorovic smorovic changed the title Streamer output modules ported to one::OutputModule (75X) Streamer output modules ported to one::OutputModule (74X) Sep 14, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@emeschi
Copy link
Contributor

emeschi commented Sep 14, 2015

+1

@deguio
Copy link
Contributor

deguio commented Sep 14, 2015

+1

@cmsbuild
Copy link
Contributor

+1
Tested at: caed04f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11245/8046/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11245/8046/summary.html

@Dr15Jones
Copy link
Contributor

+1

@cvuosalo
Copy link
Contributor

+1

For #11254 caed04f

Migrating streamer output modules to one::OutputModule to support multi-threading. There should be no change in monitored quantities. #11115 and #11116 are the 76X and 75X versions of this PR, and they have both been merged.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_4_X_2015-09-13-1100 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 17, 2015
@cmsbuild
Merge pull request #11245 from smorovic/one-StreamerOutputModule-74X
c5fe44a 
Streamer output modules ported to one::OutputModule (74X)
@cmsbuild cmsbuild merged commit c5fe44a into cms-sw:CMSSW_7_4_X Sep 17, 2015
@fwyzard fwyzard mentioned this pull request Sep 21, 2015
Closed
@fwyzard
Copy link
Contributor

fwyzard commented Sep 21, 2015

tracked at #11317

@smorovic smorovic deleted the one-StreamerOutputModule-74X branch September 23, 2015 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available core-approved daq-approved dqm-approved fully-signed reconstruction-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.
8 participants
@smorovic @cmsbuild @Dr15Jones @emeschi @deguio @cvuosalo @davidlange6 @fwyzard