Fix premature end of run in DAQ (74X)

[smorovic]

In case of multiple pending lumisections in builder unit (ramdisk), recently forced behavior is to cycle the framework through each LS (previously source was skipping to the last one having raw data that needs to be processed). This change uncovered a loophole in logic allowing run to end prematurely if end of run file (written by BU) is in ramdisk, and there are still at least two empty lumisections followed by a LS with some raw data to process.
Fix is to allow the run to be closed only if no new files/lumisections have been discovered by source after EoR file has already been written to the input directory.

[cmsbuild]

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_7_4_X.

Fix premature end of run in DAQ (74X)

It involves the following packages:

EventFilter/Utilities

@mommsen, @cvuosalo, @cmsbuild, @emeschi, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[smorovic]

@cmsbuild please test

[davidlange6]

please test

On Sep 6, 2015, at 10:22 AM, Srecko Morovic <[email protected]mailto:[email protected]> wrote:

@cmsbuildhttps://github.com/cmsbuild please test

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/11156#issuecomment-138052001.

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 6283f73
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11156/7915/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11156/7915/summary.html

[cvuosalo]

+1

For #11156 6283f73

Bug fix related to lumi sections. There should be no change in monitored quantities.

The code change is satisfactory, and Jenkins tests against baseline CMSSW_7_4_X_2015-09-05-2300 show no significant differences, as expected.

[emeschi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1