-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix premature end of run in DAQ (75X) #11157
Conversation
…ext LS is signalled to input source *correct initialization of variable ls
A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_7_5_X. Fix premature end of run in DAQ (75X) It involves the following packages: EventFilter/Utilities @mommsen, @cvuosalo, @cmsbuild, @emeschi, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 Bug fix related to lumi sections. There should be no change in monitored quantities. #11156 is the 74X version of this PR, and it has already been approved by Reco. The code change is satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-09-06-2300 show no significant differences, as expected. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Fix premature end of run in DAQ (75X)
In case of multiple pending lumisections in builder unit (ramdisk), recently forced behavior is to cycle the framework through each LS (previously source was skipping to the last one, in case on raw data needs to be processed). This change uncovered a loophole in logic allowing run to end prematurely if end of run file (written by BU) is in ramdisk, but there is still at least two empty lumisections and then some data to process.
Fix is to allow the run to be closed only if no new files/lumisections have been discovered by source after EoR file has already been written to the input directory.
This was submitted in 74X as #11156