Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

74x Fireworks: Adjust camera position when open 3D region #11215

Merged
merged 5 commits into from
Sep 18, 2015

Conversation

alja
Copy link
Contributor

@alja alja commented Sep 9, 2015

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2015

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_7_4_X.

74x Fireworks: Adjust camera position when open 3D region

It involves the following packages:

Fireworks/Core

@cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@alja
Copy link
Contributor Author

alja commented Sep 9, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 18, 2015
74x Fireworks: Adjust camera position when open 3D region
@cmsbuild cmsbuild merged commit 5f32591 into cms-sw:CMSSW_7_4_X Sep 18, 2015
@alja alja deleted the clipcamera branch May 11, 2017 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants