75x Fireworks: Adjust camera position when open 3D region

[alja]

Forward port of #11215

[alja]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_7_5_X.

75x Fireworks: Adjust camera position when open 3D region

It involves the following packages:

Fireworks/Core

@cmsbuild can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[davidlange6]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

-1
Tested at: 279472d
I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 8 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

#define CommoTools_Utils_ExpressionSetter_h
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        CommonTools_Utils_ExpressionSetter_h
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_5_X_2015-09-09-2300/src/Fireworks/Core/src/FWHLTValidator.cc 
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_5_X_2015-09-09-2300/src/Fireworks/Core/src/FWISpyView.cc 
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_5_X_2015-09-09-2300/src/Fireworks/Core/src/FWGUIManager.cc:677:70: error: expression result unused [-Werror,-Wunused-value]
         parse("theta()", grammar.use_parser<1>() >> end_p, space_p).full;
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_5_X_2015-09-09-2300/src/Fireworks/Core/src/FWGUIManager.cc:679:68: error: expression result unused [-Werror,-Wunused-value]
         parse("phi()", grammar.use_parser<1>() >> end_p, space_p).full;
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11217/7992/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[alja]

-1 found errror in merge

[alja]

+1
fix clang error came back from failed merge

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

Pull request #11217 was updated. @cmsbuild can you please check and sign again.

[davidlange6]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

+1
Tested at: 25eef25
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11217/8011/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1

On Sep 11, 2015, at 9:28 AM, cmsbuild <[email protected]mailto:[email protected]> wrote:

+1
Tested at: 25eef2525eef25
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11217/8011/summary.html

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/11217#issuecomment-139472111.