Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CorrectedJetProducer: change into a global::EDProducer (76x) #11301

Merged
merged 2 commits into from
Sep 22, 2015
Merged

CorrectedJetProducer: change into a global::EDProducer (76x) #11301

merged 2 commits into from
Sep 22, 2015

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Sep 16, 2015

change all specialisations of CorrectedJetProducer into
global::EDProducer modules:

  • CorrectedCaloJetProducer
  • CorrectedPFJetProducer
  • CorrectedJPTJetProducer
  • CorrectedTrackJetProducer
  • CorrectedGenJetProducer

@fwyzard
CorrectedJetProducer: change into a global::EDProducer
3a2eecb 
change all specialisations of `CorrectedJetProducer` into
`global::EDProducer` modules:
  - `CorrectedCaloJetProducer`
  - `CorrectedPFJetProducer`
  - `CorrectedJPTJetProducer`
  - `CorrectedTrackJetProducer`
  - `CorrectedGenJetProducer`
@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Sep 16, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_6_X.

CorrectedJetProducer: change into a global::EDProducer (76x)

It involves the following packages:

JetMETCorrections/Modules

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @mmarionncern, @jdolen, @nhanvtran, @schoef, @mariadalfonso, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 16, 2015

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 16, 2015

tracked at #10964

@fwyzard fwyzard mentioned this pull request Sep 16, 2015
Closed
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 3a2eecb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11301/8147/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
3dddcd8
a55deef
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11301/8147/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11301/8147/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11301/8147/summary.html

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 18, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #11301 was updated. @cmsbuild, @vadler, @monttj can you please check and sign again.

@fwyzard fwyzard mentioned this pull request Sep 18, 2015
Merged
@cmsbuild
Copy link
Contributor

+1
Tested at: cf64a75
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11301/8191/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11301/8191/summary.html

@monttj
Copy link
Contributor

monttj commented Sep 22, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 22, 2015
@cmsbuild
Merge pull request #11301 from fwyzard/global_CorrectedJetProducer_76x
1af0623 
CorrectedJetProducer: change into a global::EDProducer (76x)
@cmsbuild cmsbuild merged commit 1af0623 into cms-sw:CMSSW_7_6_X Sep 22, 2015
@fwyzard fwyzard deleted the global_CorrectedJetProducer_76x branch September 23, 2015 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved comparison-available fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.
4 participants
@fwyzard @cmsbuild @monttj @davidlange6