Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multithreading fix for 74x: CorrectedJetProducer #11343

Merged
merged 2 commits into from
Oct 9, 2015
Merged

multithreading fix for 74x: CorrectedJetProducer #11343

merged 2 commits into from
Oct 9, 2015

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Sep 18, 2015

change all specialisations of CorrectedJetProducer into
global::EDProducer modules:

  • CorrectedCaloJetProducer
  • CorrectedPFJetProducer
  • CorrectedJPTJetProducer
  • CorrectedTrackJetProducer
  • CorrectedGenJetProducer

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 18, 2015

backport #11300 / #11301 to 74x

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 18, 2015

please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Sep 18, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_4_X.

CorrectedJetProducer: change into a global::EDProducer (74x)

It involves the following packages:

JetMETCorrections/Modules

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @mmarionncern, @jdolen, @nhanvtran, @schoef, @mariadalfonso, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 18, 2015

tracked at #11317

@cmsbuild
Copy link
Contributor

+1
Tested at: da3428d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11343/8192/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11343/8192/summary.html

@fwyzard fwyzard mentioned this pull request Sep 21, 2015
Closed
@monttj
Copy link
Contributor

monttj commented Sep 22, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@fwyzard
CorrectedJetProducer: change into a global::EDProducer
f9b64a9 
change all specialisations of `CorrectedJetProducer` into
`global::EDProducer` modules:
  - `CorrectedCaloJetProducer`
  - `CorrectedPFJetProducer`
  - `CorrectedJPTJetProducer`
  - `CorrectedTrackJetProducer`
  - `CorrectedGenJetProducer`
@fwyzard
replace GNU/C99 VLA with std::vector
8abe2ba
@fwyzard fwyzard force-pushed the multithreading_74x_CorrectedJetProducer branch from da3428d to 8abe2ba Compare September 23, 2015 19:02
@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 23, 2015

rebased to merge on top of both CMSSW_7_4_X and CMSSW_7_4_12_patch4

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #11343 was updated. @cmsbuild, @vadler, @monttj can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1
Tested at: 8abe2ba
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11343/8306/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11343/8306/summary.html

@monttj
Copy link
Contributor

monttj commented Sep 24, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 9, 2015
@cmsbuild
Merge pull request #11343 from fwyzard/multithreading_74x_CorrectedJe…
bc6a35b 
…tProducer

multithreading fix for 74x: CorrectedJetProducer
@cmsbuild cmsbuild merged commit bc6a35b into cms-sw:CMSSW_7_4_X Oct 9, 2015
@fwyzard fwyzard deleted the multithreading_74x_CorrectedJetProducer branch October 10, 2015 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved comparison-available fully-signed tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.
4 participants
@fwyzard @cmsbuild @monttj @davidlange6