bsunanda:Run2-hcx60 Provide hexgonal geometry for HGCal #12845

bsunanda · 2015-12-23T18:36:59Z

This will give simulation as well as reconstruction geometry for HGCal (square as well as hexgonal cell). The hook for DB will require some work from Yana.
@kpedro88 @lgray Please take a look

bsunanda · 2015-12-23T18:37:21Z

@cmsbuild Please test

cmsbuild · 2015-12-23T18:37:53Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10384/console

cmsbuild · 2015-12-23T18:37:54Z

A new Pull Request was created by @bsunanda for CMSSW_8_0_X.

It involves the following packages:

CondFormats/GeometryObjects
Configuration/Geometry
DataFormats/ForwardDetId
Geometry/CaloTopology
Geometry/HGCalCommonData
Geometry/HGCalGeometry
SimCalorimetry/HGCalSimProducers
SimDataFormats/CaloTest
SimG4CMS/Calo

@civanch, @diguida, @ianna, @mdhildreth, @cmsbuild, @franzoni, @Dr15Jones, @cerminar, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @vandreev11, @sethzenz, @makortel, @apfeiffer1, @kpedro88, @lgray, @cseez, @pfs, @tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

+1|approve[d]|sign[ed]: L1/L2's to approve it
-1|reject[ed]: L1/L2's to reject it
assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
hold: L1/all L2's/release manager to mark it as on hold
unhold: L1/user who put this PR on hold
merge: L1/release managers to merge this request
[@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
[@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

cmsbuild · 2015-12-23T20:14:30Z

+1
Tested at: 82ee3ab
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12845/10384/summary.html

lgray · 2015-12-23T20:18:59Z

Hi Sunanda, is the default geometry still square in this setup?

lgray · 2015-12-23T20:23:55Z

How do I import this geometry into a CMSSW config? Is there an example config?
Don't see one in the files for this commit.

cmsbuild · 2015-12-23T20:56:41Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12845/10384/summary.html

bsunanda · 2015-12-23T22:34:19Z

I did not provide a new config because David always picks on that. I tested this using a test python file in Geometry/HGCalCommonData/python/testHGCXML_cfi.py. I can make a second such in Geometry/CMSCommonData and Configuration/Geometry. But I shall put them in a separate PR.

From: Lindsey Gray [[email protected]]
Sent: 23 December 2015 21:24
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-hcx60 Provide hexgonal geometry for HGCal (#12845)

How do I import this geometry into a CMSSW config? Is there an example config?
Don't see one in the files for this commit.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/12845#issuecomment-166984297.

lgray · 2015-12-23T23:59:42Z

If you can provide a V7 config privately I'll be able to check that things
start to make sense. Just send me something by email.

-L

On Wed, Dec 23, 2015 at 10:34 PM, bsunanda [email protected] wrote:

I did not provide a new config because David always picks on that. I
tested this using a test python file in
Geometry/HGCalCommonData/python/testHGCXML_cfi.py. I can make a second such
in Geometry/CMSCommonData and Configuration/Geometry. But I shall put them
in a separate PR.

From: Lindsey Gray [[email protected]]
Sent: 23 December 2015 21:24
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-hcx60 Provide hexgonal geometry for
HGCal (#12845)

How do I import this geometry into a CMSSW config? Is there an example
config?
Don't see one in the files for this commit.

—
Reply to this email directly or view it on GitHub<
https://github.com/cms-sw/cmssw/pull/12845#issuecomment-166984297>.

—
Reply to this email directly or view it on GitHub
#12845 (comment).

ianna · 2015-12-24T08:50:31Z

CondFormats/GeometryObjects/interface/HGCalParameters.h

+    bool               used;
+    CLHEP::Hep3Vector  h3v;
+    CLHEP::HepRotation hr;
+  };


@bsunanda - this object should define what is stored to/retrieved from DB. I think, using vectors of doubles is better.

bsunanda · 2015-12-30T19:23:25Z

@cmsbuild Please test

cmsbuild · 2015-12-30T19:23:26Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10408/console

cmsbuild · 2015-12-30T20:20:50Z

Pull request #12845 was updated. @civanch, @diguida, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @franzoni, @Dr15Jones, @cerminar, @slava77, @ggovi, @mmusich, @davidlange6 can you please check and sign again.

bsunanda · 2015-12-30T20:21:45Z

@cmsbuild Please test

cmsbuild · 2015-12-30T20:22:05Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10410/console

cmsbuild · 2015-12-30T22:29:05Z

+1
Tested at: 2be0fda
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12845/10408/summary.html

cmsbuild · 2015-12-30T23:11:05Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12845/10408/summary.html

cmsbuild · 2015-12-30T23:15:34Z

+1
Tested at: d51b973
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12845/10410/summary.html

cmsbuild · 2015-12-30T23:58:44Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12845/10410/summary.html

slava77 · 2015-12-31T15:46:55Z

+1

for #12845 d51b973

since 9ef390e, the changes are only in Geometry/HGCalCommonData and do not affect reco
jenkins tests pass and comparisons show no differences

ianna · 2016-01-04T10:02:31Z

@bsunanda - please, close this PR. #12862 should replace it. Thanks.

ianna · 2016-01-04T13:20:27Z

-1

Provide hexgonal geometry for HGCal

82ee3ab

cmsbuild added this to the Next CMSSW_8_0_X milestone Dec 23, 2015

cmsbuild added simulation-pending alca-pending db-pending geometry-pending pending-signatures tests-pending labels Dec 23, 2015

cmsbuild added orp-pending comparison-pending labels Dec 23, 2015

cmsbuild added tests-started and removed tests-pending labels Dec 23, 2015

cmsbuild added tests-approved and removed tests-started labels Dec 23, 2015

cmsbuild added comparison-available and removed comparison-pending labels Dec 23, 2015

ianna reviewed Dec 24, 2015
View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Dec 30, 2015

Needed for validation work

d51b973

cmsbuild added tests-pending and removed tests-started labels Dec 30, 2015

cmsbuild added tests-started and removed tests-pending labels Dec 30, 2015

bsunanda mentioned this pull request Dec 30, 2015

Run2-hcx62 Validation toolket for HGCAL #12857

Merged

cmsbuild added comparison-available and removed comparison-pending labels Dec 30, 2015

cmsbuild added tests-approved and removed tests-started labels Dec 30, 2015

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Dec 31, 2015

ianna mentioned this pull request Jan 4, 2016

HGcal Hexgonal Geometry #12862

Merged

cmsbuild added geometry-rejected and removed geometry-pending labels Jan 4, 2016

davidlange6 closed this Jan 4, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bsunanda:Run2-hcx60 Provide hexgonal geometry for HGCal #12845

bsunanda:Run2-hcx60 Provide hexgonal geometry for HGCal #12845

bsunanda commented Dec 23, 2015

bsunanda commented Dec 23, 2015

cmsbuild commented Dec 23, 2015

cmsbuild commented Dec 23, 2015

cmsbuild commented Dec 23, 2015

lgray commented Dec 23, 2015

lgray commented Dec 23, 2015

cmsbuild commented Dec 23, 2015

bsunanda commented Dec 23, 2015

lgray commented Dec 23, 2015

ianna Dec 24, 2015

bsunanda commented Dec 30, 2015

cmsbuild commented Dec 30, 2015

cmsbuild commented Dec 30, 2015

bsunanda commented Dec 30, 2015

cmsbuild commented Dec 30, 2015

cmsbuild commented Dec 30, 2015

cmsbuild commented Dec 30, 2015

cmsbuild commented Dec 30, 2015

cmsbuild commented Dec 30, 2015

slava77 commented Dec 31, 2015

ianna commented Jan 4, 2016

ianna commented Jan 4, 2016

bsunanda:Run2-hcx60 Provide hexgonal geometry for HGCal #12845

bsunanda:Run2-hcx60 Provide hexgonal geometry for HGCal #12845

Conversation

bsunanda commented Dec 23, 2015

bsunanda commented Dec 23, 2015

cmsbuild commented Dec 23, 2015

cmsbuild commented Dec 23, 2015

cmsbuild commented Dec 23, 2015

lgray commented Dec 23, 2015

lgray commented Dec 23, 2015

cmsbuild commented Dec 23, 2015

bsunanda commented Dec 23, 2015

lgray commented Dec 23, 2015

ianna Dec 24, 2015

Choose a reason for hiding this comment

bsunanda commented Dec 30, 2015

cmsbuild commented Dec 30, 2015

cmsbuild commented Dec 30, 2015

bsunanda commented Dec 30, 2015

cmsbuild commented Dec 30, 2015

cmsbuild commented Dec 30, 2015

cmsbuild commented Dec 30, 2015

cmsbuild commented Dec 30, 2015

cmsbuild commented Dec 30, 2015

slava77 commented Dec 31, 2015

ianna commented Jan 4, 2016

ianna commented Jan 4, 2016