HGcal Hexgonal Geometry #12862

ianna · 2016-01-04T10:01:35Z

Merge Sunanda's bsunanda:Run2-hcx60 branch
Fix conflicts
Move HGCalParameters class to common HGCal directory
Add a schema for HGCalParameters as PHGCalParameters
Add serialization test for a new schema PHGCalParameters

Replaces #12845

Conflicts: CondFormats/GeometryObjects/src/classes.h CondFormats/GeometryObjects/src/classes_def.xml

* Add a schema for HGCalParameters as PHGCalParameters * Add serialization test for a new schema PHGCalParameters * Fix conflicts

cmsbuild · 2016-01-04T10:01:58Z

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_8_0_X.

It involves the following packages:

CondFormats/GeometryObjects
Configuration/Geometry
DataFormats/ForwardDetId
Geometry/CaloGeometry
Geometry/CaloTopology
Geometry/HGCalCommonData
Geometry/HGCalGeometry
RecoLocalCalo/HGCalRecProducers
SimCalorimetry/HGCalSimProducers
SimDataFormats/CaloTest
SimG4CMS/Calo

@civanch, @diguida, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @franzoni, @Dr15Jones, @cerminar, @slava77, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @vandreev11, @sethzenz, @makortel, @apfeiffer1, @kpedro88, @lgray, @cseez, @pfs, @tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

+1|approve[d]|sign[ed]: L1/L2's to approve it
-1|reject[ed]: L1/L2's to reject it
assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
hold: L1/all L2's/release manager to mark it as on hold
unhold: L1/user who put this PR on hold
merge: L1/release managers to merge this request
[@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
[@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

ianna · 2016-01-04T10:02:49Z

@cmsbuild please test

cmsbuild · 2016-01-04T10:03:11Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10418/console

cmsbuild · 2016-01-04T11:44:21Z

+1
Tested at: 95fcf83
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12862/10418/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
9933046
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12862/10418/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12862/10418/git-merge-result

cmsbuild · 2016-01-04T12:29:07Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12862/10418/summary.html

ianna · 2016-01-04T13:18:35Z

+1

slava77 · 2016-01-04T20:19:22Z

+1

for #12862 95fcf83

from reco perspective, this is equivalent to already signed bsunanda:Run2-hcx60 Provide hexgonal geometry for HGCal #12845 d51b973
jenkins tests pass and comparisons with the baseline show no differences

ianna · 2016-01-05T09:08:38Z

@slava77 - this PR is the same as you've already signed (just moving files around).
@ggovi and @diguida - this is a first iteration of a new schema for HGCal parameters. Please, let me know if you have time to look at it. I'd like to integrate the PR ASAP as it involves changes in DataFormats. Alternatively, I can remove the schema from this PR to speed up its integration. Thanks.

mmusich · 2016-01-07T08:13:02Z

+1
adding PHGCalParameters CondFormat

mmusich · 2016-01-07T08:13:18Z

@ggovi please have a look too

ggovi · 2016-01-07T09:59:53Z

+1

ianna · 2016-01-08T07:21:49Z

@civanch - could you, please, have a look? Thanks.

davidlange6 · 2016-01-08T14:30:11Z

Geometry/HGCalCommonData/data/v1/hgcalEE.xml

@@ -110,6 +110,7 @@
  <SpecPar name="HGCalEE">
    <PartSelector path="//HGCalEESensitive.*"/>
    <Parameter name="Volume" value="HGCalEESensitive" eval="false"/>
+    <Parameter name="GeometryMode" value="HGCalGeometryMode::Square" eval="false"/>


@ianna - do I understand this code correctly to say that in each xml we have a line to which "GeometryMode" we do NOT use? Could we not make this more descriptive by giving the GeometryMode we DO use instead?

@davidlange6 - your assumption is not correct. HGCal "GeometryMode" is used starting from this PR. It is either a square or a hexagon reflecting its sensors shape.

ok Thanks!

On Jan 8, 2016, at 4:48 PM, Ianna Osborne [email protected] wrote:

In Geometry/HGCalCommonData/data/v1/hgcalEE.xml:

@@ -110,6 +110,7 @@

@davidlange6 - your assumption is not correct. HGCal "GeometryMode" is used starting from this PR. It is either a square or a hexagon reflecting its sensors shape.

—
Reply to this email directly or view it on GitHub.

civanch · 2016-01-08T15:59:00Z

+1

cmsbuild · 2016-01-08T15:59:24Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 · 2016-01-08T16:02:17Z

+1

On Jan 8, 2016, at 4:59 PM, cmsbuild [email protected] wrote:

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

—
Reply to this email directly or view it on GitHub.

HGcal Hexgonal Geometry

Sunanda and others added 8 commits December 23, 2015 19:33

Provide hexgonal geometry for HGCal

82ee3ab

Take into account Iana's comments

c1209d4

Modify the cff's with HGCal

aafd23b

Update the geometry file usage in test

9ef390e

Bug fix

2be0fda

Needed for validation work

d51b973

Merged Run2-hcx60 from repository bsunanda

9933046

Conflicts: CondFormats/GeometryObjects/src/classes.h CondFormats/GeometryObjects/src/classes_def.xml

* Move HGCalParameters class to common HGCal directory

95fcf83

* Add a schema for HGCalParameters as PHGCalParameters * Add serialization test for a new schema PHGCalParameters * Fix conflicts

cmsbuild added this to the Next CMSSW_8_0_X milestone Jan 4, 2016

cmsbuild added reconstruction-pending simulation-pending alca-pending db-pending geometry-pending pending-signatures tests-pending orp-pending comparison-pending labels Jan 4, 2016

ianna mentioned this pull request Jan 4, 2016

bsunanda:Run2-hcx60 Provide hexgonal geometry for HGCal #12845

Closed

cmsbuild added tests-started and removed tests-pending labels Jan 4, 2016

cmsbuild added tests-approved and removed tests-started labels Jan 4, 2016

cmsbuild added comparison-available and removed comparison-pending labels Jan 4, 2016

cmsbuild added geometry-approved and removed geometry-pending labels Jan 4, 2016

ianna mentioned this pull request Jan 4, 2016

bsunanda:Run2-hcx61 Make the 2023Dev Geometry configuration for the HGCal V7 version #12847

Closed

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jan 4, 2016

cmsbuild added alca-approved and removed alca-pending labels Jan 7, 2016

cmsbuild added db-approved and removed db-pending labels Jan 7, 2016

davidlange6 reviewed Jan 8, 2016
View reviewed changes

cmsbuild added simulation-approved fully-signed and removed pending-signatures simulation-pending labels Jan 8, 2016

cmsbuild added orp-approved and removed orp-pending labels Jan 8, 2016

cmsbuild added a commit that referenced this pull request Jan 8, 2016

Merge pull request #12862 from ianna/hgcal-hexgonal-geometry

f3046c6

HGcal Hexgonal Geometry

cmsbuild merged commit f3046c6 into cms-sw:CMSSW_8_0_X Jan 8, 2016

slava77 mentioned this pull request Jan 8, 2016

HGCal DB Parameters Writer #12888

Merged

ianna deleted the hgcal-hexgonal-geometry branch January 13, 2016 10:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HGcal Hexgonal Geometry #12862

HGcal Hexgonal Geometry #12862

ianna commented Jan 4, 2016

cmsbuild commented Jan 4, 2016

ianna commented Jan 4, 2016

cmsbuild commented Jan 4, 2016

cmsbuild commented Jan 4, 2016

cmsbuild commented Jan 4, 2016

ianna commented Jan 4, 2016

slava77 commented Jan 4, 2016

ianna commented Jan 5, 2016

mmusich commented Jan 7, 2016

mmusich commented Jan 7, 2016

ggovi commented Jan 7, 2016

ianna commented Jan 8, 2016

davidlange6 Jan 8, 2016

ianna Jan 8, 2016

davidlange6 Jan 8, 2016

civanch commented Jan 8, 2016

cmsbuild commented Jan 8, 2016

davidlange6 commented Jan 8, 2016

HGcal Hexgonal Geometry #12862

HGcal Hexgonal Geometry #12862

Conversation

ianna commented Jan 4, 2016

cmsbuild commented Jan 4, 2016

ianna commented Jan 4, 2016

cmsbuild commented Jan 4, 2016

cmsbuild commented Jan 4, 2016

cmsbuild commented Jan 4, 2016

ianna commented Jan 4, 2016

slava77 commented Jan 4, 2016

ianna commented Jan 5, 2016

mmusich commented Jan 7, 2016

mmusich commented Jan 7, 2016

ggovi commented Jan 7, 2016

ianna commented Jan 8, 2016

davidlange6 Jan 8, 2016

Choose a reason for hiding this comment

ianna Jan 8, 2016

Choose a reason for hiding this comment

davidlange6 Jan 8, 2016

Choose a reason for hiding this comment

civanch commented Jan 8, 2016

cmsbuild commented Jan 8, 2016

davidlange6 commented Jan 8, 2016