Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print deprecation warning if anybody uses phase1TkCustoms without phase1Pixel era #13503

Merged
merged 1 commit into from
Mar 2, 2016

Conversation

makortel
Copy link
Contributor

Title says it all. Suggested by @slava77 in https://github.com/cms-sw/cmssw/pull/13477/files#r54273167. I used the message in postLS1Customs.py as a template.

Tested in CMSSW_8_1_X_2016-02-23-2300, no changes expected.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X.

It involves the following packages:

SLHCUpgradeSimulations/Configuration

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@civanch
Copy link
Contributor

civanch commented Feb 26, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11587/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Feb 29, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 2, 2016
Print deprecation warning if anybody uses phase1TkCustoms without phase1Pixel era
@cmsbuild cmsbuild merged commit a1a67c6 into cms-sw:CMSSW_8_1_X Mar 2, 2016
@makortel makortel deleted the addDeprecationWarning2017 branch October 20, 2016 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants