-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print deprecation warning if anybody uses phase1TkCustoms without phase1Pixel era #13503
Print deprecation warning if anybody uses phase1TkCustoms without phase1Pixel era #13503
Conversation
…) without phase1Pixel era set
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X. It involves the following packages: SLHCUpgradeSimulations/Configuration @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
Print deprecation warning if anybody uses phase1TkCustoms without phase1Pixel era
Title says it all. Suggested by @slava77 in https://github.com/cms-sw/cmssw/pull/13477/files#r54273167. I used the message in
postLS1Customs.py
as a template.Tested in CMSSW_8_1_X_2016-02-23-2300, no changes expected.