Migrate 2017 tracking to eras #13477
Conversation
…ckingPhase1 era Disabling cluster check is migrated to phase1Pixel era, since that depends on the detector and is needed for all tracking configurations.
|
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X. It involves the following packages: RecoMuon/Configuration @civanch, @cvuosalo, @mdhildreth, @cmsbuild, @deguio, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
@Dr15Jones You might be interested as well to see how the discussion in #13194 and https://hypernews.cern.ch/HyperNews/CMS/get/edmFramework/3597.html materialized in the end. |
| ], | ||
| BPix = dict(TTRHBuilder = "TTRHBuilderWithoutAngle4PixelPairs"), | ||
| FPix = dict(TTRHBuilder = "TTRHBuilderWithoutAngle4PixelPairs"), | ||
| TIB1 = dict(clusterChargeCut = dict(refToPSet_ = "SiStripClusterChargeCutNone")), |
There was a problem hiding this comment.
NOTE: since the value just repeats dict(clusterChargeCut = dict(refToPSet_ = "SiStripClusterChargeCutNone")) you could declare that as a variable and just use the variable for each assigned value.
_clusterChargeCut = dict(clusterChargeCut = dict(refToPSet_ = "SiStripClusterChargeCutNone"))
eras.trackingPhase1.toModify(convLayerPairs,
...
TIB1 = _clusterChargeCut,
TIB2 = _clusterChargeCut,
...
)There was a problem hiding this comment.
We could also remove copy-paste by having single instances of TIB, TID, and TOB instead of explicitly repeating them for all layers (the underlaying code supports that and that's used elsewhere in tracking configuration). Point taken, but I'd leave it for later cleanup unless something else needing fixes pops up in the review.
|
-1 runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log 135.4 step1 runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log you can see the results of the tests here: |
|
Extended test in progress... |
|
FastSim seems to be broken in the IB. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
@deguio, @vanbesien Could you please review and sign? Subsequent development is starting to pile up. Thanks. |
|
@deguio, @vanbesien Could you please review and sign? Subsequent developments are piling up. Thanks. |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
This PR migrates the iterative tracking customization for 2017 from
phase1TkCustomstotrackingPhase1andphase1Pixeleras, as discussed in Feb 17 RECO meeting https://indico.cern.ch/event/489288/session/4/contribution/11/attachments/1230229/1803017/slides_phase1_trk_reco.pdf.As a first step "displaced muon" configuration is modified to not to import from iterative tracking configurations (imports from there within the same application will just cause headache; but are the tracking internal sequences really needed here at all?).
The TTRHBuilder customization is set to depend on the
phase1Pixelera since it depends on the detector configuration and is the same for any 2017 tracking configuration. Although it is a temporary customization, I decided to "erafy" it because it is expected to be "fixed" around June (and I hopephase1TkCustoms.pyis long gone by then). All occurrances of this and other temporary customizations should be found withgit grep "phase1Pixe.*FIXME".Subsequent steps are
phase1TkCustoms.customise_Reco()to erastrackingPhase1era totrackingPhase1PU70era, and put the "new phase1 tracking" (from Update phase1 (2017) tracking sequence #13149) to undertrackingPhase1eraTested in CMSSW_8_1_X_2016-02-23-2300 with
runTheMatrix.py -i all -l limitedfor <= 2016 and-w upgrade -l 10000,10039for 2017 workflows. No changes are expected in monitored quantities (expanded job configuration files do change for both 2016 and 2017, but are functionally equivalent before and after this PR).This is purely technical PR, no changes are expected.
@rovere @VinInn