Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows for 2023 including Phase2 Tracker (gensim step) #13537

Closed
wants to merge 11 commits into from

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Mar 1, 2016

This is including the phase2 Tracker in the gensim workflow:

  • As discussed in the sim meeting I started to populate the
  • 2023sim working up to gensim with 2015 where I replaced the run2 Tracker with the phase2 Flat Tracker from the run2 one (2015 scenario)
  • 2023dev working up to gensim with 2015 where I replaced the run2 Tracker with the phase2 Tilted Tracker from the run2 one (2015 scenario)

In addition to the tracker change , I add to remove from the 2015 scenario those xml conflicting ( I didn't manage to solve)
'Geometry/ForwardCommonData/data/pltbcm.xml',
'Geometry/ForwardCommonData/data/bcm1f.xml',
'Geometry/ForwardSimData/data/bcm1fsens.xml',
'Geometry/ForwardCommonData/data/plt.xml',

to test :
for 2023sim:
runTheMatrix.py --what upgrade -l 10800
fro 2023dev:
runTheMatrix.py --what upgrade -l 10600

If everything goes well, the local reco will be added (in 2023LReco ) scenario but let's first check this PR

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2016

A new Pull Request was created by @boudoul (boudoul) for CMSSW_8_1_X.

It involves the following packages:

Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
Geometry/CMSCommonData
SLHCUpgradeSimulations/Configuration
SLHCUpgradeSimulations/Geometry

@civanch, @Dr15Jones, @boudoul, @ianna, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @franzoni, @hengne, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @cerati, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@boudoul
Copy link
Contributor Author

boudoul commented Mar 1, 2016

@delaere FYI

@VinInn
Copy link
Contributor

VinInn commented Mar 2, 2016

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11661/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2016

@ianna
Copy link
Contributor

ianna commented Mar 2, 2016

@boudoul - Could you, please ask Gabrielle Hugo for new xml files to fix erroneous shapes in Tracker definition? We've discussed it a month ago in an e-mail thread. Alternatively, I can provide a patch for your PR with fixes. Please, let me know.

Thanks.

*** Shape tracker:Tracker: TGeoPcon ***
    Nz    = 16
    phi1  =     0.00000
    dphi  =   360.00000
     plane 0: z= -291.00000 Rmin=    7.40000 Rmax=  120.00000
     plane 1: z= -270.65000 Rmin=    7.40000 Rmax=  120.00000
     plane 2: z= -270.65000 Rmin=    7.40000 Rmax=  120.00000
     plane 3: z= -194.80000 Rmin=    2.50000 Rmax=  120.00000
     plane 4: z= -180.00000 Rmin=    2.50000 Rmax=  120.00000
     plane 5: z= -180.00000 Rmin=    7.70000 Rmax=  120.00000
     plane 6: z= -172.20000 Rmin=    7.70000 Rmax=  120.00000
     plane 7: z= -172.20000 Rmin=    2.50000 Rmax=  120.00000
     plane 8: z=  172.20000 Rmin=    2.50000 Rmax=  120.00000
     plane 9: z=  172.20000 Rmin=    7.70000 Rmax=  120.00000
     plane 10: z=  180.00000 Rmin=    7.70000 Rmax=  120.00000
     plane 11: z=  180.00000 Rmin=    2.50000 Rmax=  120.00000
     plane 12: z=  194.80000 Rmin=    2.50000 Rmax=  120.00000
     plane 13: z=  270.65000 Rmin=    7.40000 Rmax=  120.00000
     plane 14: z=  270.65000 Rmin=    7.40000 Rmax=  120.00000
     plane 15: z=  291.00000 Rmin=    7.40000 Rmax=  120.00000
 Bounding box:
*** Shape tracker:Tracker: TGeoBBox ***
    dX =     0.00000
    dY =     0.00000
    dZ =     0.00000
    origin: x=    0.00000 y=    0.00000 z=    0.00000
----- Begin Fatal Exception 02-Mar-2016 16:14:46 CET-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'p'
   [2] Calling event method for module DumpSimGeometry/'dump'
   [3] Using EventSetup component TGeoMgrFromDdd/'' to make data TGeoManager/'' in record DisplayGeomRecord
   Additional Info:
      [a] Fatal Root Error: @SUB=TGeoPcon::ComputeBBox
Duplicated section 1/2 for shape tracker:Tracker

----- End Fatal Exception -------------------------------------------------

to be in synch with Ianna's fix PR cms-sw#13583
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2016

Pull request #13537 was updated. @civanch, @Dr15Jones, @boudoul, @ianna, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @franzoni, @hengne, @davidlange6 can you please check and sign again.

To to be in synch with Ianna's fix PR cms-sw#13583
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2016

Pull request #13537 was updated. @civanch, @Dr15Jones, @boudoul, @ianna, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @franzoni, @hengne, @davidlange6 can you please check and sign again.

@boudoul
Copy link
Contributor Author

boudoul commented Mar 9, 2016

I managed to screw up my branch when updating it , therefore I'm closing this PR, and just created a new one which is the same as this one but adressing the comments from @ianna see now : PR #13671

@boudoul boudoul closed this Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants