Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Extra Plane in Pixel Service Cylinder Polycone #13583

Merged
merged 1 commit into from
Mar 6, 2016
Merged

Remove Extra Plane in Pixel Service Cylinder Polycone #13583

merged 1 commit into from
Mar 6, 2016

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Mar 3, 2016

  • Fix for both Flat and Tilted Tracker scenarios

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Mar 3, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2016

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_8_1_X.

It involves the following packages:

Geometry/TrackerCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @ghellwig, @VinInn, @venturia this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@ianna
Copy link
Contributor Author

ianna commented Mar 3, 2016

@boudoul - this fixes the crash reported in newly defined scenarios PR #13537

@ianna
Copy link
Contributor Author

ianna commented Mar 3, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11696/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2016

+1
Tested at: cf9ebbd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13583/11696/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13583/11696/summary.html

@ianna
Copy link
Contributor Author

ianna commented Mar 3, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Mar 6, 2016
@davidlange6
Merge pull request #13583 from ianna/2023-tracker-fix
3138a01 
Remove Extra Plane in Pixel Service Cylinder Polycone
@davidlange6 davidlange6 merged commit 3138a01 into cms-sw:CMSSW_8_1_X Mar 6, 2016
boudoul added a commit to boudoul/cmssw that referenced this pull request Mar 8, 2016
@boudoul
Update pixFwCylinder
1131c64 
to be in synch with Ianna's fix PR cms-sw#13583
boudoul added a commit to boudoul/cmssw that referenced this pull request Mar 8, 2016
@boudoul
Update pixFwCylinder
8de1270 
To to be in synch with Ianna's fix PR cms-sw#13583
@boudoul boudoul mentioned this pull request Mar 9, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed geometry-approved orp-pending tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.
3 participants
@ianna @cmsbuild @davidlange6