Fix a minor error in DQM/L1TMonitor BuildFile #13619
Conversation
It needs to generate a proper edm plugin.
|
A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_8_1_X. It involves the following packages: DQM/L1TMonitor @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
Fix a minor error in DQM/L1TMonitor BuildFile
|
as this is now proper plugin so other package e.g. DQMOffline/L1Trigger can not link against it. You need tio cleanup this dependency. We have a build errror due to this in IBs |
|
@davidlange6 , we need to revert it (if there is no fix already approved) to get a working IB |
|
ok, thanks. I will ask dmitrijus to submit a proper fix. |
|
cms-checkdeps should have checked out DQMOffline/L1Trigger locally and then it should have failed but looks like cms-checkdeps is not reading the full dependency information from the patch and full release. I am looking in to this. |
|
OK, it is not that bad. It does read the dependency information for headers and python files but not for BuildFiles. This needs to be fixed in cmsdist for building patch releases. I will update cmsdist to generate full dependency information for BuildFiles too. |
|
Did not expect this package to be a dependency, just plugins. |
It needs to generate a proper edm plugin.