-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a minor error in DQM/L1TMonitor BuildFile #13620
Conversation
It needs to generate a proper edm plugin.
A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_8_0_X. It involves the following packages: DQM/L1TMonitor @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
Comparison not run due to Fireworks only changes (RelVals and Igprof tests were also skipped) |
-1 L1TSync_Offline.cc:(.text+0x50c5): undefined reference to `L1TMenuHelper::L1TMenuHelper(edm::EventSetup const&)' L1TSync_Offline.cc:(.text+0x50ec): undefined reference to`L1TMenuHelper::testAlgos(std::map, std::allocator > > const&)' L1TSync_Offline.cc:(.text+0x51f0): undefined reference to `L1TMenuHelper::getLUSOTrigger(std::map, std::allocator > > const&, int, L1GtUtils const&)' L1TSync_Offline.cc:(.text+0x5a9d): undefined reference to`L1TMenuHelper::~L1TMenuHelper()' L1TSync_Offline.cc:(.text+0x5d88): undefined reference to `L1TMenuHelper::~L1TMenuHelper()' collect2: error: ld returned 1 exit status gmake: **\* [tmp/slc6_amd64_gcc493/src/DQMOffline/L1Trigger/src/DQMOfflineL1Trigger/libDQMOfflineL1Trigger.so] Error 1 Leaving library rule at DQMOffline/L1Trigger --- Registered EDM Plugin: DQMServicesStreamerIOPlugins >> Leaving Package DQMServices/StreamerIO >> Package DQMServices/StreamerIO built you can see the results of the tests here: |
@dmitrijus |
-1 |
It needs to generate a proper edm plugin.
(backport of #13619)