-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up aging.py and set up HB TDR aging #18452
Conversation
@cmsbuild please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @kpedro88 (Kevin Pedro) for master. It involves the following packages: CalibCalorimetry/HcalPlugins @ghellwig, @civanch, @arunhep, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @mmusich, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
-1 Tested at: 4cf01b6 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
more eos/xrootd problems, awesome |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
+1 |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
Comparison is ready Comparison Summary:
|
+1 |
Followup to #18118 to set up the aging customise functions for the barrel TDR. I removed a bunch of very old stuff from aging.py, and added a set of functions and corresponding HCAL conditions for the agreed-upon aging scenarios:
Currently the HCAL conditions ignore the lumi ramp-up period after LS3/4 and just use the final instantaneous lumi (for simplicity).
For future reference, here are the two HL-LHC schedules: