Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up aging.py and set up HB TDR aging #18452

Merged
merged 2 commits into from
Apr 25, 2017
Merged

Conversation

kpedro88
Copy link
Contributor

Followup to #18118 to set up the aging customise functions for the barrel TDR. I removed a bunch of very old stuff from aging.py, and added a set of functions and corresponding HCAL conditions for the agreed-upon aging scenarios:

i) 300 fb-1, 1000fb-1 and 3000fb-1 with an instantaneous luminosity of 5E34, the nominal scenario
ii) 3000fb-1 and 4500fb-1 with an instantaneous luminosity of 7.5E34, the ultimate scenario

Currently the HCAL conditions ignore the lumi ramp-up period after LS3/4 and just use the final instantaneous lumi (for simplicity).

For future reference, here are the two HL-LHC schedules:
HL-LHC schedules

@kpedro88
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 24, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19353/console Started: 2017/04/24 22:25

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

CalibCalorimetry/HcalPlugins
SLHCUpgradeSimulations/Configuration

@ghellwig, @civanch, @arunhep, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @mmusich, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @sviret, @Martin-Grunewald, @tocheng, @ebrondol this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@cmsbuild
Copy link
Contributor

-1

Tested at: 4cf01b6

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18452/19353/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@kpedro88
Copy link
Contributor Author

more eos/xrootd problems, awesome

@kpedro88
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 25, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19390/console Started: 2017/04/25 16:52

@kpedro88
Copy link
Contributor Author

+1

@civanch
Copy link
Contributor

civanch commented Apr 25, 2017

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@arunhep
Copy link
Contributor

arunhep commented Apr 25, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18452/19390/summary.html

Comparison Summary:

  • You potentially added 32 lines to the logs
  • Reco comparison results: 1639 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1780076
  • DQMHistoTests: Total failures: 6167
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1773736
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e7360be into cms-sw:master Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants