Update on the muon shower trigger for startup Run-3 (HadronicShowerTrigger-7) #35886

dildick · 2021-10-28T15:56:15Z

PR description:

For startup Run-3 we aim to have 2 trigger modes for muon shower: (1) >=1 nominal shower (main trigger for physics analysis) and (2) >=1 tight shower (backup trigger for physics analysis).

This PR introduces the tight showers in the EMTF and uGMT.
It also removes the out-of-time trigger option (something that needs more study during Run-3).
The >=2 loose showers option is disabled since we're not considering that for Run-3 either (also needs more study).
The anode and cathode thresholds were updated following optimization studies with Zerobias samples for rate and MC signal samples for efficiency.
A layer requirement of >=5 layers was added to the cathode and anode showers to reduce the trigger rate.
Finally, the shower trigger in the motherboard requires by default the presence of an anode shower and a cathode shower (also reduces the trigger rate).

Relevant presentation here: https://indico.cern.ch/event/1090753/contributions/4585330/attachments/2335554/3980792/CSCShower_SD_20211027.pdf

PR validation:

Code compiles. Tested with Run-2 ZeroBias and Run-3 MC samples.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@tahuang1991 @Nik-Menendez

…tartup Run-3

…move out-of-time triggers for startup Run-3. Add anode AND cathode case

cmsbuild · 2021-10-28T16:03:35Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35886/26283

This PR adds an extra 72KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/L1TMuon/interface/RegionalMuonShower.h modified in PR(s): (Un)packers for hadronic showers at the uGMT input and output #35627
- File DataFormats/L1TMuon/src/RegionalMuonShower.cc modified in PR(s): (Un)packers for hadronic showers at the uGMT input and output #35627
- File DataFormats/L1TMuon/src/classes_def.xml modified in PR(s): (Un)packers for hadronic showers at the uGMT input and output #35627
- File L1Trigger/L1TMuonEndCap/interface/SectorProcessorShower.h modified in PR(s): (Un)packers for hadronic showers at the uGMT input and output #35627
- File L1Trigger/L1TMuonEndCap/src/SectorProcessorShower.cc modified in PR(s): (Un)packers for hadronic showers at the uGMT input and output #35627

cmsbuild · 2021-10-28T16:03:57Z

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DataFormats/L1TMuon (l1)
DataFormats/L1Trigger (l1)
L1Trigger/CSCTriggerPrimitives (l1)
L1Trigger/L1TMuon (l1)
L1Trigger/L1TMuonEndCap (l1)

@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@valuev, @kreczko, @rovere, @Martin-Grunewald, @missirol, @thomreis, @dinyar, @ptcox this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

dildick · 2021-10-28T16:39:04Z

Interesting WF 11634.0 fails in CMSSW_12_1_X_2021-10-27-2300 with

DIGI:pdigi_valid,L1,DIGI2RAW,HLT:@relval2021,ENDJOB
We have determined that this is simulation (if not, rerun cmsDriver.py with --data)
with DB:
entry file:step1.root
Step: DIGI Spec: ['pdigi_valid']
Step: L1 Spec: 
Traceback (most recent call last):
  File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_1_X_2021-10-27-2300/bin/slc7_amd64_gcc900/cmsDriver.py", line 56, in <module>
    run()
  File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_1_X_2021-10-27-2300/bin/slc7_amd64_gcc900/cmsDriver.py", line 28, in run
    configBuilder.prepare()
  File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_1_X_2021-10-27-2300/python/Configuration/Applications/ConfigBuilder.py", line 2170, in prepare
    self.addStandardSequences()
  File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_1_X_2021-10-27-2300/python/Configuration/Applications/ConfigBuilder.py", line 784, in addStandardSequences
    getattr(self,"prepare_"+stepName)(sequence = getattr(self,stepName+"DefaultSeq"))
  File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_1_X_2021-10-27-2300/python/Configuration/Applications/ConfigBuilder.py", line 1512, in prepare_L1
    self.loadAndRemember(self.L1EMDefaultCFF)
  File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_1_X_2021-10-27-2300/python/Configuration/Applications/ConfigBuilder.py", line 327, in loadAndRemember
    self.process.load(includeFile)
  File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_1_X_2021-10-27-2300/python/FWCore/ParameterSet/Config.py", line 695, in load
    module = __import__(moduleName)
  File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_1_X_2021-10-27-2300/python/Configuration/StandardSequences/SimL1Emulator_cff.py", line 3, in <module>
    from L1Trigger.Configuration.SimL1Emulator_cff import *
  File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_1_X_2021-10-27-2300/python/L1Trigger/Configuration/SimL1Emulator_cff.py", line 33, in <module>
    from L1Trigger.Configuration.SimL1TechnicalTriggers_cff import *
  File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_1_X_2021-10-27-2300/python/L1Trigger/Configuration/SimL1TechnicalTriggers_cff.py", line 4, in <module>
    import L1Trigger.L1TGlobal.simGtExtFakeProd_cfi
ModuleNotFoundError: No module named 'L1Trigger.L1TGlobal.simGtExtFakeProd_cfi'

dildick · 2021-11-02T18:22:42Z

WF 11634.0 seems to work in CMSSW_12_2_X_2021-11-02-1100

dildick · 2021-11-02T21:02:02Z

Can someone initiate the tests, please?

qliphy · 2021-11-03T00:57:58Z

please test

cmsbuild · 2021-11-03T03:59:53Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b544f6/20210/summary.html
COMMIT: 1148d95
CMSSW: CMSSW_12_2_X_2021-11-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35886/20210/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 42
DQMHistoTests: Total histograms compared: 2901890
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2901868
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
Checked 177 log files, 37 edm output root files, 42 DQM output files
TriggerResults: no differences found

rekovic · 2021-11-03T12:01:22Z

+1

cmsbuild · 2021-11-03T12:01:46Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-11-03T14:28:05Z

@dildick , even if it is not in the part of the code that you modified, since it is in one file that you modified, could you please take care of the static analyzer warning which points out to an uncorrect usage of variable debugTimeBins in L1Trigger/CSCTriggerPrimitives/src/CSCCathodeLCTProcessor.cc ?

The same static analyzer report also points out a few other rather obvious mistakes/bugs in the code that should be better addressed, in a different PR but possibly rather soon. For example:

this shows that the slope computed in the first part of CSCGEMMatcher::calculateGEMCSCBending is actually never used
this shows the same issue with debugTimeBins in L1Trigger/CSCTriggerPrimitives/src/CSCMotherboard.cc

dildick · 2021-11-03T14:44:47Z

@perrotta For the static analyzer, do you have an example solution that would not throw static warnings? I suppose I could just remove the debugTimeBins flag and have the (very unlikely) warning print for every event it is relevant.

dildick · 2021-11-03T14:45:17Z

The calculateGEMCSCBending is a work in progress. It will be used soon.

perrotta · 2021-11-03T14:51:03Z

@perrotta For the static analyzer, do you have an example solution that would not throw static warnings? I suppose I could just remove the debugTimeBins flag and have the (very unlikely) warning print for every event it is relevant.

Yes, I would do exactly the same (possibly for both files here, since you are there) . By the way, having hardcoded the value of true for it does exactly the same

perrotta · 2021-11-03T14:52:21Z

The calculateGEMCSCBending is a work in progress. It will be used soon.

... and this is a good reason to remove/fix obvious flaws since now (not in this PR, though)

dildick · 2021-11-03T15:00:44Z

@perrotta I'll open up a separate PR for the static warnings. For the calculateGEMCSCBending function, I'll need to check with a coworker what the status is.

perrotta · 2021-11-03T15:36:15Z

+1

Static analyzer issues are/will be addressed in Get rid of static warnings in CSC trigger emulator #35972

Sven Dildick added 5 commits October 28, 2021 09:53

Add tight muon shower case for startup Run-3

d06a01f

Add tight showers. Remove out-of-time showers, since not needed for s…

ce20b80

…tartup Run-3

Add layer requirement in trigger. Update cathode/anode thresholds. Re…

afbbe4a

…move out-of-time triggers for startup Run-3. Add anode AND cathode case

Take out the ouf-of-time triggers for startup Run-3

58dfae7

Fix typo

1148d95

cmsbuild added this to the CMSSW_12_1_X milestone Oct 28, 2021

cmsbuild added code-checks-pending l1-pending orp-pending pending-signatures tests-pending labels Oct 28, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 28, 2021

smuzaffar modified the milestones: CMSSW_12_1_X, CMSSW_12_2_X Oct 29, 2021

cmsbuild added tests-started and removed tests-pending labels Nov 3, 2021

cmsbuild added tests-approved and removed tests-started labels Nov 3, 2021

cmsbuild added fully-signed and removed l1-pending pending-signatures labels Nov 3, 2021

cmsbuild added the l1-approved label Nov 3, 2021

dildick mentioned this pull request Nov 3, 2021

Get rid of static warnings in CSC trigger emulator #35972

Merged

cmsbuild added orp-approved and removed orp-pending labels Nov 3, 2021

cmsbuild merged commit fb74fa2 into cms-sw:master Nov 3, 2021

dildick deleted the from-CMSSW_12_1_X_2021-10-27-2300-update-muon-shower-trigger branch November 3, 2021 17:30

dildick changed the title ~~Update on the muon shower trigger for startup Run-3~~ Update on the muon shower trigger for startup Run-3 (HadronicShowerTrigger-6) Nov 6, 2021

dildick changed the title ~~Update on the muon shower trigger for startup Run-3 (HadronicShowerTrigger-6)~~ Update on the muon shower trigger for startup Run-3 (HadronicShowerTrigger-7) Nov 6, 2021

dildick mentioned this pull request Nov 6, 2021

uGT framework and L1 ntuples for showers in the muon system for Run-3 (HadronicShowerTrigger-8) #36018

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update on the muon shower trigger for startup Run-3 (HadronicShowerTrigger-7) #35886

Update on the muon shower trigger for startup Run-3 (HadronicShowerTrigger-7) #35886

dildick commented Oct 28, 2021

cmsbuild commented Oct 28, 2021

cmsbuild commented Oct 28, 2021

dildick commented Oct 28, 2021

dildick commented Nov 2, 2021

dildick commented Nov 2, 2021

qliphy commented Nov 3, 2021

cmsbuild commented Nov 3, 2021

rekovic commented Nov 3, 2021

cmsbuild commented Nov 3, 2021

perrotta commented Nov 3, 2021

dildick commented Nov 3, 2021

dildick commented Nov 3, 2021

perrotta commented Nov 3, 2021

perrotta commented Nov 3, 2021

dildick commented Nov 3, 2021

perrotta commented Nov 3, 2021

Update on the muon shower trigger for startup Run-3 (HadronicShowerTrigger-7) #35886

Update on the muon shower trigger for startup Run-3 (HadronicShowerTrigger-7) #35886

Conversation

dildick commented Oct 28, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Oct 28, 2021

cmsbuild commented Oct 28, 2021

dildick commented Oct 28, 2021

dildick commented Nov 2, 2021

dildick commented Nov 2, 2021

qliphy commented Nov 3, 2021

cmsbuild commented Nov 3, 2021

Comparison Summary

rekovic commented Nov 3, 2021

cmsbuild commented Nov 3, 2021

perrotta commented Nov 3, 2021

dildick commented Nov 3, 2021

dildick commented Nov 3, 2021

perrotta commented Nov 3, 2021

perrotta commented Nov 3, 2021

dildick commented Nov 3, 2021

perrotta commented Nov 3, 2021