Get rid of static warnings in CSC trigger emulator

[dildick]

PR description:

In response to #35886 (comment). It's just two if statements around logwarnings around that were removed, so there should not be any changes in workflows.

PR validation:

Code compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@perrotta @tahuang1991

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35972/26397

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/CSCTriggerPrimitives/src/CSCCathodeLCTProcessor.cc modified in PR(s): Update on the muon shower trigger for startup Run-3 (HadronicShowerTrigger-7) #35886
  • File L1Trigger/CSCTriggerPrimitives/src/CSCMotherboard.cc modified in PR(s): Update on the muon shower trigger for startup Run-3 (HadronicShowerTrigger-7) #35886

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

• L1Trigger/CSCTriggerPrimitives (l1)

@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@valuev, @missirol, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

Just to keep track of it, one should also fix the CSCGEMMatcher: the slope computed in the first part of CSCGEMMatcher::calculateGEMCSCBending is actually never used, which witnesses a possible bug in the code implemented in that method

[dildick]

@perrotta Can you run the tests?

[perrotta]

please test

[dildick]

Thanks!

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-012295/20230/summary.html
COMMIT: 5ff3d4e
CMSSW: CMSSW_12_2_X_2021-11-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35972/20230/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 2901890
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2901862
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[dildick]

fyi @rathjd

[dildick]

@perrotta Results look good.

[dildick]

FYI @giovanni-mocellin

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1