Replace Geometry_cff with GeometryDB_cff in RecoLocalTracker

[jeongeun]

PR description:
Review on the Reco part of #31113

process.load("Configuration.StandardSequences.Geometry_cff")
was outdated #8810
It should be replaced with
process.load("Configuration.StandardSequences.GeometryDB_cff")

In this PR, RecoLocalTracker configuration files (3 files) are fixed.

        modified:   RecoLocalTracker/SiPixelClusterizer/test/readClusters_cfg.py
        modified:   RecoLocalTracker/SiPixelRecHits/test/readRecHits_cfg.py
        modified:   RecoLocalTracker/SiStripRecHitConverter/test/DigisToRecHitRead_cfg.py

PR validation:

Tested in CMSSW_12_5_X, the basic test all passed in the CMSSW PR instructions

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38552/30786

• This PR adds an extra 16KB to repository

[clacaputo]

@cmsbuild please test

[cmsbuild]

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

• RecoLocalTracker/SiPixelClusterizer (reconstruction)
• RecoLocalTracker/SiPixelRecHits (reconstruction)
• RecoLocalTracker/SiStripRecHitConverter (reconstruction)

@jpata, @clacaputo can you please review it and eventually sign? Thanks.
@echabert, @ferencek, @yduhm, @swertz, @gpetruc, @GiacomoSguazzoni, @pieterdavid, @robervalwalsh, @JanFSchulte, @rovere, @VinInn, @alesaggio, @OzAmram, @felicepantaleo, @mtosi, @gbenelli, @mmusich, @dkotlins, @threus, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

hi @jeongeun @clacaputo when we move to GeometryDB_cff that means the Geometry is taken from the DB, i.e. through the GT. So the GT part of these codes should be updated too, for example this file uses this very old GT:

cmssw/RecoLocalTracker/SiPixelClusterizer/test/readClusters_cfg.py

Line 83 in 1d8095c

process.GlobalTag.globaltag = 'PRE_R_71_V3::All'

can you change that line to
process.GlobalTag.globaltag = 'auto:phase1_2022_realistic'
(in the other files too)
thanks!

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-08bfe9/25981/summary.html
COMMIT: 1d8095c
CMSSW: CMSSW_12_5_X_2022-07-04-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38552/25981/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3654771
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3654741
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[clacaputo]

+reconstruction

• technical PR
• no reco changes

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[tvami]

hold

• see Replace Geometry_cff with GeometryDB_cff in RecoLocalTracker #38552 (comment)

[cmsbuild]

Pull request has been put on hold by @tvami
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[tvami]

@cmsbuild , please test

[perrotta]

assign alca

[cmsbuild]

New categories assigned: alca

@yuanchao,@francescobrivio,@malbouis,@tvami,@ChrisMisan you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-08bfe9/25993/summary.html
COMMIT: 1c87f9b
CMSSW: CMSSW_12_5_X_2022-07-05-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38552/25993/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3654771
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3654741
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-08bfe9/26007/summary.html
COMMIT: 1c87f9b
CMSSW: CMSSW_12_5_X_2022-07-06-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38552/26007/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3654771
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3654735
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

[clacaputo]

+reconstruction

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1