-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration.StandardSequences.Geometry_cff Not found #31113
Comments
A new Issue was created by @vargasa Andres Vargas. @Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
Why even keep the |
assign operations |
New categories assigned: operations @fabiocos,@franzoni,@qliphy,@davidlange6,@silviodonato you have been requested to review this Pull request/Issue and eventually sign? Thanks |
assign geometry |
New categories assigned: geometry @Dr15Jones,@cvuosalo,@mdhildreth,@makortel,@ianna,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks |
@vargasa - indeed, these configurations did not pick up a correct geometry anyway and should either be updated or removed. |
@makortel - I'd suggest to divide this issue per subsystem since these configurations maintenance falls under their responsibility. |
@cvuosalo - the message is out of date as well - it should be pointing to https://github.com/cms-sw/cmssw/blob/b5f6b9b7758ac90fa6540debc635ff1e6f10a580/Configuration/StandardSequences/python/GeometryDB_cff.py |
assign alca, db, reconstruction, analysis, simulation, visualization, hlt, l1 |
@ianna Done (although in many cases, if the list of files to be edited is not "large", it can be more efficient to just do it by oneself). |
Hello @makortel the bot somehow missed "assign". As pointed out by @guitargeek is there any responsible for |
assign alca, db, reconstruction, analysis, simulation, visualization, hlt, l1 |
New categories assigned: visualization,hlt,db,analysis,alca,reconstruction,l1,simulation @Dr15Jones,@mdhildreth,@slava77,@ggovi,@benkrikler,@christopheralanwest,@tlampen,@pohsun,@santocch,@rekovic,@perrotta,@makortel,@jpata,@tocheng,@alja,@Martin-Grunewald,@civanch,@fwyzard you have been requested to review this Pull request/Issue and eventually sign? Thanks |
Thanks.
In principle
Perhaps. The hard part is in figuring how unused it actually is. With
as the only real dependence outside of ElectroWeakAnalysis . That might be easy to deal with (e.g. is the testPatRecoElectrons.py itself needed?)Another question is then if any user code (outside of cmssw repo) is depending on ElectroWeakAnalysis .
|
We could add almost all of PhysicsTools/Utilities to this if ElectroWeakAnalysis was removed.. [a few other packages use LumiReWeighting.h]
On Aug 21, 2020, at 5:28 PM, Matti Kortelainen <[email protected]<mailto:[email protected]>> wrote:
the bot somehow missed "assign"
Thanks.
As pointed out by @guitargeek<https://github.com/guitargeek> is there any responsible for ElectroWeakAnalysis?
In principle analysis (@santocch<https://github.com/santocch>).
If nobody is using it is not probably better to remove it from the repo?
Perhaps. The hard part is in figuring how unused it actually is. With git grep I see
https://github.com/cms-sw/cmssw/blob/1c72cd9057477b502e754e44390ddeb62eb2f57d/HLTriggerOffline/Egamma/test/testPatRecoElectrons.py#L65
as the only real dependence outside of ElectroWeakAnalysis. That might be easy to deal with (e.g. is the testPatRecoElectrons.py itself needed?)
Another question is then if any user code (outside of cmssw repo) is depending on ElectroWeakAnalysis.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#31113 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ73S2Q2KJQOQJXFS6TSB2HANANCNFSM4P2NSDVQ>.
|
Can you suggest a replacement for |
87 references are left. They must be all unused configs. None of the references are in Geometry files. |
+1 |
+reconstruction |
+hlt Done in #40571. |
+analysis
|
@cmsbuild , please close
|
Configuration.StandardSequences.Geometry_cff
was removed a while ago: #8810See:
cmssw/Configuration/StandardSequences/python/Geometry_cff.py
Line 4 in b5f6b9b
The following files are still making reference to it: (maybe some cleanup is needed?)
Edit
See below:
From @ianna:
The text was updated successfully, but these errors were encountered: