-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BeamSpot in Run3 MC GTs + swap Run3RoundOptics25ns13TeVLowSigmaZ
with Realistic25ns13p6TeVEarly2022Collision
vtx smearing
#38760
Update BeamSpot in Run3 MC GTs + swap Run3RoundOptics25ns13TeVLowSigmaZ
with Realistic25ns13p6TeVEarly2022Collision
vtx smearing
#38760
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38760/31084
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@civanch, @Dr15Jones, @jordan-martins, @bsunanda, @makortel, @bbilin, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @clacaputo, @kskovpen, @jpata can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
@mmusich @francescobrivio please add back here the commit from #38692 that was reverted in the master, see #38762 (comment) |
7a64187
to
4bc7dca
Compare
done. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38760/31089
|
+Upgrade #39041 is OK now. |
@cms-sw/simulation-l2 can you please re-sign? |
test parameters:
|
@cmsbuild, please test |
+1 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b625f/27074/summary.html Comparison SummarySummary:
|
unhold
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
on a side note, it's sad that issue #38980 is not solved yet, as it would have been good to check the differences in more detail at https://tinyurl.com/2jkb6wmw |
some observations from the relmon for wf 11834.0 (TTBar 2021, 14TeV + PU) the off-centering of the new BeamSpot is clearly visible: the quality of the IP w.r.t. BeamSpot is similar: but for some reason we are reconstructing substantially less (?) tracks: the same effect is NOT visible in the non-PU wf 11634.0 (TTbar 2021, 14TeV) |
+1 |
PR description:
PR #38692 changed the default Beam Spot in the Run-3 Global Tag , but it was thn now out-of-synch with the vertex smearing assumed for the Run-3 RelVal workflows, even if it is correct for the 2022 physics MC.
This PR fixes the problem by making
Realistic25ns13p6TeVEarly2022Collision
the default for Run-3 relval workflows and wherever it is necessary to change it in standalone configurations together with the BeamSpot updates in the Run-3 MC GlobalTags.In this PR we add:
The new BeamSpot tags are:
BeamSpotObjects_Realistic25ns_13p6TeVCollisions_Early2022_v3_mc
BeamSpotOnlineObjects_Realistic25ns_13p6TeVCollisions_Early2022_v2_mc
The GT diffs are:
PR validation:
cmssw
compilesIf this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
to be backported together with other updates to 12.4.X
cc:
@cms-sw/alca-l2