Update PU for Run3 wfs #39041

kskovpen · 2022-08-11T19:57:09Z

PR description:

Update MinBias datasets for 2021, 2023, 2024, and 2021FS Run3 PU wfs, following the discussion in #38760.

PR validation:

Tested on 11834.0,12634.0,13034.0,13434.0,12234.0

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport.

cmsbuild · 2022-08-11T20:03:51Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39041/31527

This PR adds an extra 48KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Update BeamSpot in Run3 MC GTs + swap Run3RoundOptics25ns13TeVLowSigmaZ with Realistic25ns13p6TeVEarly2022Collision vtx smearing #38760

cmsbuild · 2022-08-11T20:04:14Z

A new Pull Request was created by @kskovpen for master.

It involves the following packages:

Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

kskovpen · 2022-08-11T20:04:48Z

test parameters:

workflow = 11834.0,12634.0,13034.0

kskovpen · 2022-08-11T20:05:23Z

please test

cmsbuild · 2022-08-12T01:00:53Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca1e69/26774/summary.html
COMMIT: 860d91e
CMSSW: CMSSW_12_5_X_2022-08-11-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39041/26774/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca1e69/26774/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca1e69/26774/git-merge-result

DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

11601.0DAS Error
11602.0DAS Error
11603.0DAS Error

Expand to see more relval errors ...

11604.0
11605.0
11606.0
11630.0
11725.0
11925.0

Comparison Summary

Summary:

You potentially added 235 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 9336 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4016058
DQMHistoTests: Total failures: 23138
DQMHistoTests: Total nulls: 4
DQMHistoTests: Total successes: 3992894
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 3.4220000000000006 KiB( 52 files compared)
DQMHistoSizes: changed ( 11834.0 ): 3.900 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 12634.0 ): 0.811 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 13034.0 ): -1.289 KiB SiStrip/MechanicalView
Checked 220 log files, 59 edm output root files, 53 DQM output files
TriggerResults: found differences in 4 / 52 workflows

srimanob · 2022-08-12T02:34:09Z

@kskovpen
How do you plan for FastSim? Thanks.

mmusich · 2022-08-12T05:49:59Z

Configuration/PyReleaseValidation/python/relval_steps.py

@@ -3710,11 +3710,11 @@ def gen2021HiMix(fragment,howMuch):
 defaultDataSets['2017Design']='CMSSW_12_0_0_pre4-113X_mc2017_design_v5-v'
 defaultDataSets['2018']='CMSSW_12_0_0_pre4-113X_upgrade2018_realistic_v5-v'
 defaultDataSets['2018Design']='CMSSW_12_0_0_pre4-113X_upgrade2018_design_v5-v'
-defaultDataSets['2021']='CMSSW_12_0_0_pre4-120X_mcRun3_2021_realistic_v2-v'
+defaultDataSets['2021']='CMSSW_12_5_0_pre4-124X_mcRun3_2022_realistic_v10-v'


Hi @kskovpen let me understand.
Are these samples done using the vtx smearing as of #38760 ?

They use Run3RoundOptics25ns13TeVLowSigmaZ

I am confused then.
What's the point of updating them?

Shall we use Realistic25ns13p6TeVEarly2022Collision?

yes, Run3RoundOptics25ns13TeVLowSigmaZ is the current vtx smearing while Realistic25ns13p6TeVEarly2022Collision will be the new one.

Thanks, Marco

kskovpen · 2022-08-12T06:49:42Z

@kskovpen
How do you plan for FastSim? Thanks.

It's coming.

srimanob · 2022-08-12T06:51:00Z

@kskovpen
How do you plan for FastSim? Thanks.

It's coming.

Thanks. To confirm the cmsDriver with CMSSW_12_5_0_pre4, it should come from
runTheMatrix.py --what upgrade -l 13240.303 --command="--beamspot Realistic25ns13p6TeVEarly2022Collision" --wm init

cmsbuild · 2022-08-13T09:23:30Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39041/31543

This PR adds an extra 52KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Update BeamSpot in Run3 MC GTs + swap Run3RoundOptics25ns13TeVLowSigmaZ with Realistic25ns13p6TeVEarly2022Collision vtx smearing #38760

kskovpen · 2022-08-23T16:52:11Z

The inputs for the failing wfs are now being reproduced in the newly submitted wfs. Thanks to @srimanob for additional suggestions. Let's retrigger the tests tomorrow to see if anything of these new inputs can fix the failures.

kskovpen · 2022-08-24T18:22:30Z

please test

cmsbuild · 2022-08-24T22:58:38Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca1e69/27065/summary.html
COMMIT: bcf184a
CMSSW: CMSSW_12_5_X_2022-08-24-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39041/27065/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 3149 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3693084
DQMHistoTests: Total failures: 36621
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3656440
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.983 KiB( 50 files compared)
DQMHistoSizes: changed ( 11834.0 ): 1.979 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: found differences in 2 / 50 workflows

srimanob · 2022-08-25T01:08:57Z

+Upgrade

All updated workflows run. The histogram differences come from Run-3 PU workflows (11834.0, 13434.0) where the GS (old BS simulation) is mixed with (new BS) PU in this PR. This is expected. I don't think we need to trigger the test with #38760 but as prefer. FYI @mmusich

This PR should be merged together with #38760.

srimanob · 2022-08-25T01:14:23Z

Hi @kskovpen
Thanks for all efforts of submission. Would you mind to re-submit 11725.0 with 1 core? The output can be v2, we can overwrite the version later in the code. This can come in the follow up PR. Thanks.

kskovpen · 2022-08-25T04:18:51Z

11725.0

Thanks a lot @srimanob. This workflow has been resubmitted.

kskovpen · 2022-08-25T04:21:50Z

+pdmv

Maybe a question to @smuzaffar. Do you know whether the accessed datasets in IBs are additionally copied somewhere safe? Asking this because normally there is a limited lifetime defined for the relval output datasets stored on EOS.

cmsbuild · 2022-08-25T04:22:19Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

smuzaffar · 2022-08-25T06:15:44Z

+pdmv

Maybe a question to @smuzaffar. Do you know whether the accessed datasets in IBs are additionally copied somewhere safe? Asking this because normally there is a limited lifetime defined for the relval output datasets stored on EOS.

@kskovpen , yes the dataset files opened during PR/IB tests are backed up under /eos/cms/store/user/cmsbuild/store. Note that during PR/IB tests we only process a small number of events, so we do not backup the full dataset but only keep the root files which were actually opened during PR/IB tests.

kskovpen · 2022-08-25T06:23:25Z

Thanks @smuzaffar

perrotta · 2022-08-25T14:51:32Z

+1

update pileup datasets for run3

860d91e

cmsbuild added this to the CMSSW_12_5_X milestone Aug 11, 2022

cmsbuild added code-checks-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Aug 11, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 11, 2022

cmsbuild added tests-started and removed tests-pending labels Aug 11, 2022

cmsbuild added tests-rejected and removed tests-started labels Aug 12, 2022

mmusich reviewed Aug 12, 2022

View reviewed changes

cmsbuild mentioned this pull request Aug 12, 2022

Update BeamSpot in Run3 MC GTs + swap Run3RoundOptics25ns13TeVLowSigmaZ with Realistic25ns13p6TeVEarly2022Collision vtx smearing #38760

Merged

use minbias datasets with correct beamspot

e1428da

cmsbuild added code-checks-pending tests-pending and removed tests-rejected code-checks-approved labels Aug 13, 2022

cmsbuild added the urgent label Aug 23, 2022

cmsbuild added tests-started and removed tests-rejected labels Aug 24, 2022

cmsbuild added tests-approved and removed tests-started labels Aug 24, 2022

cmsbuild added upgrade-approved and removed upgrade-pending labels Aug 25, 2022

srimanob mentioned this pull request Aug 25, 2022

[12_4_X] Update Run3 MC GTs + swap update Vertex smearing + update offline Run3 GTs #39019

Merged

cmsbuild added fully-signed pdmv-approved and removed pending-signatures pdmv-pending labels Aug 25, 2022

cmsbuild added orp-approved and removed orp-pending labels Aug 25, 2022

cmsbuild merged commit 88e6ff6 into cms-sw:master Aug 25, 2022

cmsbuild mentioned this pull request Aug 26, 2022

[GCC][PATCH] libstdc++: Mark non-exported function always_inline cms-sw/cmsdist#8039

Merged

kskovpen mentioned this pull request Sep 30, 2022

Update beamspot in 12_4_X relval samples #39548

Merged

mmusich mentioned this pull request Nov 1, 2022

[12.4.X] add ExhumeGeneratorFilter to ConcurrentLumisDisable #39949

Merged

srimanob mentioned this pull request Apr 22, 2023

Remove 12450.* wfs (2023, ZMuMu) from GPU RelVals #41386

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update PU for Run3 wfs #39041

Update PU for Run3 wfs #39041

kskovpen commented Aug 11, 2022 •

edited

Loading

cmsbuild commented Aug 11, 2022

cmsbuild commented Aug 11, 2022

kskovpen commented Aug 11, 2022

kskovpen commented Aug 11, 2022

cmsbuild commented Aug 12, 2022

srimanob commented Aug 12, 2022

mmusich Aug 12, 2022 •

edited

Loading

kskovpen Aug 12, 2022

mmusich Aug 12, 2022

kskovpen Aug 12, 2022

mmusich Aug 12, 2022

kskovpen Aug 12, 2022

kskovpen commented Aug 12, 2022

srimanob commented Aug 12, 2022 •

edited

Loading

cmsbuild commented Aug 13, 2022

kskovpen commented Aug 23, 2022

kskovpen commented Aug 24, 2022

cmsbuild commented Aug 24, 2022

srimanob commented Aug 25, 2022 •

edited

Loading

srimanob commented Aug 25, 2022

kskovpen commented Aug 25, 2022

kskovpen commented Aug 25, 2022

cmsbuild commented Aug 25, 2022

smuzaffar commented Aug 25, 2022

kskovpen commented Aug 25, 2022

perrotta commented Aug 25, 2022

Update PU for Run3 wfs #39041

Update PU for Run3 wfs #39041

Conversation

kskovpen commented Aug 11, 2022 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Aug 11, 2022

cmsbuild commented Aug 11, 2022

kskovpen commented Aug 11, 2022

kskovpen commented Aug 11, 2022

cmsbuild commented Aug 12, 2022

RelVals-INPUT

Comparison Summary

srimanob commented Aug 12, 2022

mmusich Aug 12, 2022 • edited Loading

Choose a reason for hiding this comment

kskovpen Aug 12, 2022

Choose a reason for hiding this comment

mmusich Aug 12, 2022

Choose a reason for hiding this comment

kskovpen Aug 12, 2022

Choose a reason for hiding this comment

mmusich Aug 12, 2022

Choose a reason for hiding this comment

kskovpen Aug 12, 2022

Choose a reason for hiding this comment

kskovpen commented Aug 12, 2022

srimanob commented Aug 12, 2022 • edited Loading

cmsbuild commented Aug 13, 2022

kskovpen commented Aug 23, 2022

kskovpen commented Aug 24, 2022

cmsbuild commented Aug 24, 2022

Comparison Summary

srimanob commented Aug 25, 2022 • edited Loading

srimanob commented Aug 25, 2022

kskovpen commented Aug 25, 2022

kskovpen commented Aug 25, 2022

cmsbuild commented Aug 25, 2022

smuzaffar commented Aug 25, 2022

kskovpen commented Aug 25, 2022

perrotta commented Aug 25, 2022

kskovpen commented Aug 11, 2022 •

edited

Loading

mmusich Aug 12, 2022 •

edited

Loading

srimanob commented Aug 12, 2022 •

edited

Loading

srimanob commented Aug 25, 2022 •

edited

Loading