Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PU for Run3 wfs #39041

Merged
merged 6 commits into from
Aug 25, 2022
Merged

Update PU for Run3 wfs #39041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
860d91e
update pileup datasets for run3
kskovpen Aug 11, 2022
e1428da
use minbias datasets with correct beamspot
kskovpen Aug 13, 2022
14e1a54
update minbias
kskovpen Aug 14, 2022
de3d139
update
kskovpen Aug 14, 2022
ed7ffeb
update
kskovpen Aug 18, 2022
bcf184a
update
kskovpen Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Configuration/PyReleaseValidation/python/relval_2017.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
# 2021 (DD4hep XML: TTbar, ZMM)
# (DDD DB: TTbar, ZMM)
# (ele guns 10, 35, 1000; pho guns 10, 35; mu guns 1, 10, 100, 1000, QCD 3TeV, QCD Flat)
# (ZMM, TTbar, ZEE, MinBias, TTbar PU, TTbar PU premix, ZEE PU, TTbar design, GluGluTo2Jets, GluGluTo2Jets PU)
# (ZMM, TTbar, ZEE, MinBias, TTbar PU, TTbar PU premix, ZEE PU, TTbar design)
# (TTbar trackingOnly, pixelTrackingOnly, trackingMkFit, trackdnn)
# (Patatrack pixel-only: ZMM - on CPU: quadruplets, triplets)
# (Patatrack pixel-only: TTbar - on CPU: quadruplets, triplets)
Expand Down Expand Up @@ -64,7 +64,8 @@
11634.911, 11650.911,
11634.914, 11650.914,
11601.0,11602.0,11603.0,11604.0,11605.0,11606.0,11607.0,11608.0,11609.0,11630.0,11643.0,
11650.0,11634.0,11646.0,11640.0,11834.0,11834.99,11846.0,12034.0,11725.0,11925.0,
11650.0,11634.0,11646.0,11640.0,11834.0,11834.99,11846.0,12034.0,
#11725.0,11925.0,
11634.1,11634.5,11634.7,11634.71,11634.72,11634.91,
11650.501,11650.505,
11634.501,11634.505,
Expand Down
10 changes: 5 additions & 5 deletions Configuration/PyReleaseValidation/python/relval_steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3710,11 +3710,11 @@ def gen2021HiMix(fragment,howMuch):
defaultDataSets['2017Design']='CMSSW_12_0_0_pre4-113X_mc2017_design_v5-v'
defaultDataSets['2018']='CMSSW_12_0_0_pre4-113X_upgrade2018_realistic_v5-v'
defaultDataSets['2018Design']='CMSSW_12_0_0_pre4-113X_upgrade2018_design_v5-v'
defaultDataSets['2021']='CMSSW_12_0_0_pre4-120X_mcRun3_2021_realistic_v2-v'
defaultDataSets['2021Design']='CMSSW_12_0_0_pre4-120X_mcRun3_2021_design_v2-v'
defaultDataSets['2021FS']='CMSSW_12_4_0_pre4-124X_mcRun3_2021_realistic_v1_Run3FastSim_FastSim-v'
defaultDataSets['2023']='CMSSW_12_0_0_pre4-120X_mcRun3_2023_realistic_v2-v'
defaultDataSets['2024']='CMSSW_12_0_0_pre4-120X_mcRun3_2024_realistic_v2-v'
defaultDataSets['2021']='CMSSW_12_5_0_pre4-124X_mcRun3_2022_realistic_v10_BS2022-v'
defaultDataSets['2021Design']='CMSSW_12_5_0_pre4-124X_mcRun3_2022_design_v7_design_BS2022-v'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo here? Why do we have double "design".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, das does not know about dataset=/RelValTTbar_14TeV/CMSSW_12_5_0_pre4-124X_mcRun3_2022_design_v7_design_BS2022-v1/GEN-SIM but dataset=/RelValTTbar_14TeV/CMSSW_12_5_0_pre4-124X_mcRun3_2022_design_v7_BS2022-v1/GEN-SIM is available though. So looks like a typo here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi All, thanks for your comments. It is not a typo. It is intended to have double 'design' - we had to reproduce this wf and in order not to increment the version an additional string has been appended. The dataset exists: https://cmsweb.cern.ch/das/request?instance=prod/global&input=file+dataset%3D%2FRelValMinBias_14TeV%2FCMSSW_12_5_0_pre4-124X_mcRun3_2022_design_v7_design_BS2022-v1%2FGEN-SIM. However, dasgoclient sees no data in this dataset.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kskovpen
Then you need to produce full sets of it. Currently, it has only MinBias as I see on DAS, using dataset status=* dataset=/RelVal*/CMSSW_12_5_0_pre4-124X_mcRun3_2022_design_v7_design_BS2022-v1/GEN-SIM

The missing, for example, is TTbar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, then we need to reproduce again.

defaultDataSets['2021FS']='CMSSW_12_5_0_pre4-124X_mcRun3_2022_realistic_v10_BS2022_FastSim-v'
defaultDataSets['2023']='CMSSW_12_5_0_pre4-124X_mcRun3_2023_realistic_v11_BS2022-v'
defaultDataSets['2024']='CMSSW_12_5_0_pre4-124X_mcRun3_2024_realistic_v11_BS2022-v'
Comment on lines +3713 to +3717
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the GTs used in these supposed to already contain the new beamspot? Because that's the version+1

Copy link
Contributor

@tvami tvami Aug 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmusich @francescobrivio is the payload relevant at the GS level, or the only thing that matters there is the it was created with a CMSSW software version that had the correct vertex smearing in it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BeamSpotObjectsRcd is not accessed by GEN and SIM steps, as your own twiki states.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh yes, very good! Thanks Marco!

defaultDataSets['2026D49']='CMSSW_12_0_0_pre4-113X_mcRun4_realistic_v7_2026D49noPU-v'
defaultDataSets['2026D76']='CMSSW_12_0_0_pre4-113X_mcRun4_realistic_v7_2026D76noPU-v'
defaultDataSets['2026D77']='CMSSW_12_1_0_pre2-113X_mcRun4_realistic_v7_2026D77noPU-v'
Expand Down