Update beamspot in 12_4_X relval samples #39548

kskovpen · 2022-09-30T07:03:59Z

PR description:

Follows https://its.cern.ch/jira/browse/PDMVRELVALS-171.
The new 12_4_X input samples for relval wfs are produced that use realistic beamspot, so that it is also consistent with #39041.

PR validation:

Need to wait for the production of samples.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport. This PR needs to go directly to 12_4_X for it to not interfere with the newer 12_5_X samples used in the master.

cmsbuild · 2022-09-30T07:04:26Z

A new Pull Request was created by @kskovpen for CMSSW_12_4_X.

It involves the following packages:

Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

srimanob · 2022-09-30T07:06:26Z

Hi @kskovpen
Do you also submit 11725.0 ? Or we need to comment it out in 12_4 also.

Best,
Phat

kskovpen · 2022-09-30T07:24:10Z

Hi @kskovpen Do you also submit 11725.0 ? Or we need to comment it out in 12_4 also.

Best, Phat

Hi @srimanob , yes, it has been submitted as well.

kskovpen · 2022-09-30T07:25:02Z

Let's trigger the tests - many of them will fail for now. Will do it literately on a daily basis until we converge.

kskovpen · 2022-09-30T07:25:11Z

please test

srimanob · 2022-09-30T07:31:42Z

Hi @kskovpen Do you also submit 11725.0 ? Or we need to comment it out in 12_4 also.
Best, Phat

Hi @srimanob , yes, it has been submitted as well.

Thx. Can you do it for 12_5 also, so that we can bring it back to INPUT test.

cmsbuild · 2022-09-30T08:43:30Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-356284/27873/summary.html
COMMIT: d669293
CMSSW: CMSSW_12_4_X_2022-09-29-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39548/27873/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals

11834.0

----- Begin Fatal Exception 30-Sep-2022 10:02:57 CEST-----------------------
An exception of category 'NoSecondaryFiles' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

11601.0DAS Error
11602.0DAS Error
11603.0DAS Error

Expand to see more relval errors ...

11604.0
11605.0
11606.0
11607.0
11608.0
11609.0
11630.0
11634.0
11634.1
11634.15
11634.24
11634.5
11634.501
11634.505
11634.511
11634.521
11634.601
11634.7
11634.91
11640.0
11643.0
11646.0
11650.0
11650.501
11650.505
11723.17
11725.0
11834.0
11834.13
11834.21
11834.24
11834.99
11846.0
11925.0
12034.0

kskovpen · 2022-09-30T09:39:46Z

Hi @kskovpen Do you also submit 11725.0 ? Or we need to comment it out in 12_4 also.
Best, Phat

Hi @srimanob , yes, it has been submitted as well.

Thx. Can you do it for 12_5 also, so that we can bring it back to INPUT test.

Submitted.

srimanob · 2022-10-02T16:56:28Z

Hi @kskovpen
Can you not control nstreams to be 1 for https://dmytro.web.cern.ch/dmytro/cmsprodmon/workflows.php?campaign=CMSSW_12_5_0_pre4__fullsim_BS2022_14TeV-1664530270 ?

https://cms-pdmv.cern.ch/relval/relvals?status=submitted&batch_name=fullsim_BS2022_14TeV&cmssw_release=CMSSW_12_5_0_pre4&shown=1023&page=0&limit=50

kskovpen · 2022-10-04T05:00:55Z

I recall that PU wfs run more efficiently with 2 streams.

kskovpen · 2022-10-04T05:01:28Z

@cmsbuild please test

Normally, the noPU inputs should be available.

kskovpen · 2022-10-04T05:04:07Z

please test

kskovpen · 2022-10-04T05:07:33Z

@perrotta @rappoccio not sure if the bot is operational?

perrotta · 2022-10-04T05:55:10Z

@cmsbuild please test

cmsbuild · 2022-10-04T10:55:42Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-356284/27970/summary.html
COMMIT: d669293
CMSSW: CMSSW_12_4_X_2022-10-03-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39548/27970/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

11606.0DAS Error
11725.0DAS Error
11925.0DAS Error

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 3280 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3677402
DQMHistoTests: Total failures: 8791
DQMHistoTests: Total nulls: 3
DQMHistoTests: Total successes: 3668586
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.059 KiB( 49 files compared)
DQMHistoSizes: changed ( 11834.0 ): -0.063 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 208 log files, 45 edm output root files, 50 DQM output files
TriggerResults: found differences in 1 / 49 workflows

kskovpen · 2022-11-18T20:29:53Z

Is there a unit test error now?

 
===== Test "test_CreateFileLists" ====
=======================================
This script is moved to its new home in
tkal_create_file_lists.py              
(in Alignment/CommonAlignment/scripts).
=======================================

  >>> Requested 200000 events for alignment.
  >>> Requested 200000 events for alignment.
  >>> Requesting information for the following dataset(s):
  >>> 	/MinimumBias/Run2011A-v1/RAW
  >>> This may take a while...
multiprocessing.pool.RemoteTraceback: 
"""
Traceback (most recent call last):
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02759/el8_amd64_gcc10/external/python3/3.9.6-67e5cf5b4952101922f1d4c8474baa39/lib/python3.9/multiprocessing/pool.py", line 125, in worker
    result = (True, func(*args, **kwds))
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02759/el8_amd64_gcc10/external/python3/3.9.6-67e5cf5b4952101922f1d4c8474baa39/lib/python3.9/multiprocessing/pool.py", line 48, in mapstar
    return list(map(*args))
  File "<string>", line 1110, in get_file_info
  File "<string>", line 1104, in _get_properties
  File "<string>", line 929, in das_client
UnboundLocalError: local variable 'das_data' referenced before assignment
"""

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_4_X_2022-11-18-1100/bin/el8_amd64_gcc10/mps_create_file_lists.py", line 12, in <module>
    exec(open(subprocess.check_output(["which", "tkal_create_file_lists.py"], universal_newlines=True).rstrip()).read())
  File "<string>", line 1174, in <module>
  File "<string>", line 44, in main
  File "<string>", line 120, in create
  File "<string>", line 375, in _request_dataset_information
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02759/el8_amd64_gcc10/external/python3/3.9.6-67e5cf5b4952101922f1d4c8474baa39/lib/python3.9/multiprocessing/pool.py", line 771, in get
    raise self._value
UnboundLocalError: local variable 'das_data' referenced before assignment

---> test test_CreateFileLists had ERRORS
TestTime:1381
^^^^ End Test test_CreateFileLists ^^^^

?

Looks like it - the relval input errors are solved, though.

tvami · 2022-11-18T20:35:16Z

@cms-sw/orp-l2 is this known?

perrotta · 2022-11-19T09:21:28Z

@cms-sw/orp-l2 is this known?

No, that unit test error is not present in the 12_4_X IBs.
Sometimes DAS errors come from a glitch, and the fact that it did not show up in the previous test attempts here lead me to the conclusion that it could be the case even here.
Since machines are probably not overloaded during the week end, we can give it another try.

By the way, @kskovpen @tvami : there is no need to repeat the tests when you see RelValInputs error (unless there is any hint that they can be originated by the PR inspected): they show up quite often and are well known, and normally not a reason to get alarmed.

perrotta · 2022-11-19T09:21:34Z

please test

srimanob · 2022-11-19T09:40:20Z

This PR is a special case that if we see relvals input error, we need to make sure it comes from a glitch, or it is really a missing, as it defines a new set of datasets as input.

cmsbuild · 2022-11-19T14:46:37Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-356284/29132/summary.html
COMMIT: 1bc3ea5
CMSSW: CMSSW_12_4_X_2022-11-18-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39548/29132/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

TriggerResults: found differences in 7 / 48 workflows

tvami · 2022-11-29T16:03:51Z

@srimanob please sign this PR as well

kskovpen · 2022-11-29T16:12:52Z

+pdmv

srimanob · 2022-11-29T17:54:51Z

Hi @kskovpen
Do you success to generate RelValGluGluTo2Jets_14TeV from 12_4_9_patch1? This makes this PR different from master which we still comment 2 workflows of RelValGluGluTo2Jets out (11725.0,11925.0),
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_2017.py#L69

srimanob · 2022-11-29T18:01:55Z

+Upgrade

We may need to follow up the master on RelValGluGluTo2Jets as mentioned in #39548 (comment)

cmsbuild · 2022-11-29T18:02:25Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2022-11-29T21:00:35Z

+1

mmusich · 2022-11-29T21:05:15Z

+1

great. So now the relval PU libraries will have one vertex smearing, but the signals still the the old one (awaiting #39019 to be merged)

kskovpen · 2022-12-03T07:45:25Z

Hi @kskovpen
Do you success to generate RelValGluGluTo2Jets_14TeV from 12_4_9_patch1? This makes this PR different from master which we still comment 2 workflows of RelValGluGluTo2Jets out (11725.0,11925.0),
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_2017.py#L69

Hi @srimanob , yes, these wfs were successfully generated in 12_4_9_patch1 by adding "process.options.numberOfConcurrentLuminosityBlocks = 1" to customization.

srimanob · 2022-12-03T16:32:03Z

Hi @kskovpen
Do you success to generate RelValGluGluTo2Jets_14TeV from 12_4_9_patch1? This makes this PR different from master which we still comment 2 workflows of RelValGluGluTo2Jets out (11725.0,11925.0),
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_2017.py#L69

Hi @srimanob , yes, these wfs were successfully generated in 12_4_9_patch1 by adding "process.options.numberOfConcurrentLuminosityBlocks = 1" to customization.

Hi @kskovpen
OK. I think you only need that manual customization for this time. We added ExhumeGeneratorFilter to the list of module which does not support concurrentlumiblocks in #39143, and it is available from

CMSSW_12_5_0_pre5 (that is why we have issue with 12_5_0_pre4 without manual customization).
CMSSW_12_4_11_patch1
I leave you decide to what to do with master. To generate it, or to wait until we update again the defaultDataSets['XXXX']. Note that we have fixes on geometry came in, i.e. HCAL detid which effect both Run-3 and Phase-2. I think it is better to find a moment to update GS.

update beamspot

d669293

cmsbuild added this to the CMSSW_12_4_X milestone Sep 30, 2022

cmsbuild added orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Sep 30, 2022

cmsbuild added tests-started and removed tests-pending labels Sep 30, 2022

cmsbuild added tests-rejected and removed tests-started labels Sep 30, 2022

mmusich mentioned this pull request Sep 30, 2022

[12_4_X] Update Run3 MC GTs + swap update Vertex smearing + update offline Run3 GTs #39019

Merged

cmsbuild added tests-started and removed tests-rejected labels Oct 4, 2022

cmsbuild removed the tests-started label Oct 4, 2022

cmsbuild added tests-rejected and removed tests-started labels Nov 18, 2022

cmsbuild added tests-started and removed tests-rejected labels Nov 19, 2022

cmsbuild added tests-approved and removed tests-started labels Nov 19, 2022

cmsbuild added pdmv-approved and removed pdmv-pending labels Nov 29, 2022

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Nov 29, 2022

cmsbuild added orp-approved and removed orp-pending labels Nov 29, 2022

cmsbuild merged commit 3b2d956 into cms-sw:CMSSW_12_4_X Nov 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update beamspot in 12_4_X relval samples #39548

Update beamspot in 12_4_X relval samples #39548

kskovpen commented Sep 30, 2022

cmsbuild commented Sep 30, 2022

srimanob commented Sep 30, 2022

kskovpen commented Sep 30, 2022

kskovpen commented Sep 30, 2022

kskovpen commented Sep 30, 2022

srimanob commented Sep 30, 2022

cmsbuild commented Sep 30, 2022

kskovpen commented Sep 30, 2022

srimanob commented Oct 2, 2022

kskovpen commented Oct 4, 2022 •

edited

Loading

kskovpen commented Oct 4, 2022

kskovpen commented Oct 4, 2022

kskovpen commented Oct 4, 2022

perrotta commented Oct 4, 2022

cmsbuild commented Oct 4, 2022

kskovpen commented Nov 18, 2022

tvami commented Nov 18, 2022

perrotta commented Nov 19, 2022

perrotta commented Nov 19, 2022

srimanob commented Nov 19, 2022

cmsbuild commented Nov 19, 2022

tvami commented Nov 29, 2022

kskovpen commented Nov 29, 2022

srimanob commented Nov 29, 2022

srimanob commented Nov 29, 2022

cmsbuild commented Nov 29, 2022

rappoccio commented Nov 29, 2022

mmusich commented Nov 29, 2022

kskovpen commented Dec 3, 2022

srimanob commented Dec 3, 2022

Update beamspot in 12_4_X relval samples #39548

Update beamspot in 12_4_X relval samples #39548

Conversation

kskovpen commented Sep 30, 2022

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Sep 30, 2022

srimanob commented Sep 30, 2022

kskovpen commented Sep 30, 2022

kskovpen commented Sep 30, 2022

kskovpen commented Sep 30, 2022

srimanob commented Sep 30, 2022

cmsbuild commented Sep 30, 2022

RelVals

RelVals-INPUT

kskovpen commented Sep 30, 2022

srimanob commented Oct 2, 2022

kskovpen commented Oct 4, 2022 • edited Loading

kskovpen commented Oct 4, 2022

kskovpen commented Oct 4, 2022

kskovpen commented Oct 4, 2022

perrotta commented Oct 4, 2022

cmsbuild commented Oct 4, 2022

RelVals-INPUT

Comparison Summary

kskovpen commented Nov 18, 2022

tvami commented Nov 18, 2022

perrotta commented Nov 19, 2022

perrotta commented Nov 19, 2022

srimanob commented Nov 19, 2022

cmsbuild commented Nov 19, 2022

Comparison Summary

tvami commented Nov 29, 2022

kskovpen commented Nov 29, 2022

srimanob commented Nov 29, 2022

srimanob commented Nov 29, 2022

cmsbuild commented Nov 29, 2022

rappoccio commented Nov 29, 2022

mmusich commented Nov 29, 2022

kskovpen commented Dec 3, 2022

srimanob commented Dec 3, 2022

kskovpen commented Oct 4, 2022 •

edited

Loading