Updates to PFClusterMatchedToPhotonsSelector for PF ECAL cluster calibration

[hatakeyamak]

PR description:

Updates to PFClusterMatchedToPhotonsSelector for usage in PF ECAL cluster calibration. These changes have been used for PF cluster calibration for the Run 2 UL and Run 3 calibration [1,2] through checkout of private branch, but now trying to merge to the central CMSSW for better booking.

[1] https://codimd.web.cern.ch/IwKw1T6VQw6Q8mHpvK3Mzw?view
[2] https://twiki.cern.ch/twiki/bin/view/CMS/EGMPFClusterRegression

PR validation:

Made sure that they are consistent with hartakeyamak:PfclusterCalibration_12_6_X_tmp - cleaned up version used for 12_6_X round of PF cluster calibration, and it compiles under CMSSW_13_2_0_pre3. It shouldn't make any changes to regular reco outputs (only used for the PF Cluster calibration ntuple maker [3].)

[3] https://github.com/hatakeyamak/RegressionTreeProducer/tree/PFTree_12_6_X

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is not a backport.

Cc: @jainshilpi @swagata87 @kdlong @akanugan @Nghazwani

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42436/36444

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @hatakeyamak (Kenichi Hatakeyama) for master.

It involves the following packages:

• RecoEgamma/EgammaMCTools (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @sameasy, @valsdav, @lgray, @missirol, @sobhatta, @afiqaize, @a-kapoor, @Prasant1993, @varuns23, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[swagata87]

type egamma

[mandrenguyen]

please test

[cmsbuild]

-1

Failed Tests: UnitTests RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3846ad/34028/summary.html
COMMIT: 600b3aa
CMSSW: CMSSW_13_3_X_2023-08-01-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42436/34028/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• You potentially added 5 lines to the logs
• Reco comparison results: 26 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3150821
• DQMHistoTests: Total failures: 1496
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3149303
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[hatakeyamak]

Hmm. Not sure if the failures are related to this PR.

[swagata87]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3846ad/34056/summary.html
COMMIT: 600b3aa
CMSSW: CMSSW_13_3_X_2023-08-03-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42436/34056/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 5 lines from the logs
• Reco comparison results: 16 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3150821
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3150790
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1