Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pileup 2023 august #42474

Merged
merged 3 commits into from
Aug 5, 2023
Merged

Pileup 2023 august #42474

merged 3 commits into from
Aug 5, 2023

Conversation

romeof
Copy link
Contributor

@romeof romeof commented Aug 4, 2023

PR description:

Added pileup distributions from 2023 Era C, Era D, Era C plus D and modified Mixing.py file to read these distributions.

PR validation:

Tested on CMSSW_13X.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR needs to be backported to 130X, as requested by PPD conveners.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42474/36482

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2023

A new Pull Request was created by @romeof for master.

It involves the following packages:

  • Configuration/StandardSequences (operations)
  • SimGeneral/MixingModule (simulation)

@perrotta, @rappoccio, @civanch, @mdhildreth, @cmsbuild, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @mmusich, @sameasy, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Aug 4, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a10e6/34094/summary.html
COMMIT: 963c451
CMSSW: CMSSW_13_3_X_2023-08-04-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42474/34094/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a10e6/34094/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a10e6/34094/git-merge-result

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 3413 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3150821
  • DQMHistoTests: Total failures: 1675
  • DQMHistoTests: Total nulls: 8
  • DQMHistoTests: Total successes: 3149116
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 1 / 46 workflows

@civanch
Copy link
Contributor

civanch commented Aug 5, 2023

+1

@perrotta
Copy link
Contributor

perrotta commented Aug 5, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants