Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing newlines in DataFormats modules #44230

Merged
merged 15 commits into from
Mar 5, 2024
Merged

Add missing newlines in DataFormats modules #44230

merged 15 commits into from
Mar 5, 2024

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Feb 27, 2024

PR description:

Add missing newlines at the end of the files under

DataFormats/Common
DataFormats/HcalCalibObjects
DataFormats/HepMCCandidate
DataFormats/L1Scouting
DataFormats/L1ScoutingRawData
DataFormats/L1TCalorimeterPhase2
DataFormats/L1TrackTrigger
DataFormats/L1Trigger
DataFormats/OnlineMetaData
DataFormats/Portable
DataFormats/PortableTestObjects
DataFormats/SiPixelClusterSoA
DataFormats/SoATemplate
DataFormats/TestObjects
DataFormats/TrackingRecHitSoA

.

PR validation:

None.

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 27, 2024

please test

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Feb 27, 2024
@smorovic
Copy link
Contributor

+daq

@aloeliger
Copy link
Contributor

+l1

  • Technical PR

@jfernan2
Copy link
Contributor

+1

@srimanob
Copy link
Contributor

+Upgrade

@makortel
Copy link
Contributor

+heterogeneous

@menglu21
Copy link
Contributor

menglu21 commented Mar 5, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 381ddcf into cms-sw:master Mar 5, 2024
11 checks passed
@fwyzard fwyzard deleted the add_final_newline_DataFormats branch March 5, 2024 14:26
This was referenced Mar 5, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved code-checks-approved core-approved daq-approved fully-signed generators-approved heterogeneous-approved l1-approved orp-approved reconstruction-approved tests-approved tracking trk upgrade-approved
Projects
None yet
Milestone
CMSSW_14_1_X
Development

Successfully merging this pull request may close these issues.
10 participants
@fwyzard @cmsbuild @perrotta @makortel @smorovic @aloeliger @jfernan2 @srimanob @menglu21 @antoniovilela